[17.0][MIG] partner_firstname: Migration to 17.0 #1606

moitabenfdz · 2023-11-16T15:13:14Z

No description provided.

because it's working as is

Fix pylint errors

…avoid problem with the new API [FIX] partner_firstname : Remove the value checks in tests. With Odoo v8, the value checks in tests raise a Warning "2015-02-05 08:59:44,867 4590 WARNING 00846-develop-v8-9743ea-all openerp.modules.module: Found deprecated fast_suite or checks attribute in test module openerp.addons.partner_firstname.tests. These have no effect in or after version 8.0." With Runbot, we cannot have any Warning.

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

Fix wrong naming. Remove subclassing of exception, since there is only one. Rename exception according to PEP8. Reduce tests' redundancy. Add test for whitespace trimming. Use unicode for code & tests. Fix wrong comments. Split _name_inverse adding _name_clean_inverse. Conflicts: partner_firstname/models.py Remove license header in XML files. Preserve old view names. Credits to last translator. Increase coverage. Add args to exception to display the correct message in the UI. Execute _firstname_install when installing, and log it. Rename methods to follow guidelines. Better docstrings. Workaround odoo/odoo#6324. Fix users not being able to create companies. This happened because the invert method was not being called when using the UI, and because lastname & firstname fields were required while hidden. Add new tests and fix the resulting bugs. New tests, some fail. Add docs to test modules. Fix recursive onchange misbehavior & tests. Fix UI problem when lastname was u"". It should be `False` to avoid `required` errors. Use new() to create onchange records. Reduce redundancy in tests. Tests work with `mail` module installed now. Sometimes, the only way is to just skip them.

…r model

…toring

This fixes OCA#78 and adds new tests for it.

Conflicts: partner_firstname/__openerp__.py partner_firstname/tests/__init__.py Fix flake8 error After all, this was just a workaround. Remove it. The real fix was in OCA#171. I leave the tests. Fix test that was having sentences after return. PEP8 fix.

…tics. Conflicts: partner_contact_gender/__openerp__.py

- add missing authors - use reduced license header - move models in models directory - adapt views - show firstname, lastname only in edit mode - use company_type in views instead of is_company - adapt constraint on contacts [PORT][9.0] partner_firstname - remove hack to be able to edit user view. Fixed in odoo/odoo#cf63d4d277ef1ba02ff4ebcdae8583332a1775b1 [PORT][9.0] partner_firstname - Format of string in __openerp__.py [PORT][9.0] Adapt tests to take new constraint raising IntegrityError partner_firstname: Name is not mandatory if partner is an address [FIX] Ensure default values are computed for res.users Add test for shipping address with empty name partner_firstname: fix user creation User name field is required what is stoping to create a new user Fix user form with firstname and lastname asking for a mandatory name

…f adress 'type' is contact

* Prefer odoo to openerp & remove data tags * Move exceptions file out of models * Fix string selection in xpath * Rename res_users and add import * Fix api mismatches * Add missing param * Alphabetize imports * Remove readonly from computed field * Remove deprecated api.one * Add Tecnativa * Fix icon * Fix singleton issue * Add depends to compute

partner_firstname/views/base_config_view.xml

AntoniRomera

LGTM, With the old xml it works, the change is just to make it more correct for V17, but the module works correctly in a local instance. With the old xml it works, the change is just to make it more correct for V17, but the module works correctly in a local instance.

yle-scopea · 2023-11-30T09:30:46Z

partner_firstname/static/description/index.html

@@ -0,0 +1,490 @@
+<?xml version="1.0" encoding="utf-8"?>


On Odoo.sh to have the green light on branch, we need to remove this line

This would have to be said in the mainteners repo as it creates it only when you pass the pre-commit.

MRomeera

lgtm

AntoniRomera · 2023-12-04T16:36:12Z

@pedrobaeza Can you merge it? It works correctly

pedrobaeza · 2023-12-04T16:38:36Z

/ocabot migration partner_firstname

I see a comment unattended in base_config_view.xml, isn't it?

AntoniRomera · 2023-12-04T16:41:16Z

/ocabot migration partner_firstname

I see a comment unattended in base_config_view.xml, isn't it?

Yes, but it does not affect the functionality at all, and as it stands it works fine.

pedrobaeza · 2023-12-04T16:42:27Z

But it's the new syntax to be followed, so it's preferable to be changed. @moitabenfdz can you please change it?

pedrobaeza · 2023-12-04T16:43:13Z

@AntoniRomera can you please extract a text for such conversion of the seetings to be added to the migration guide?

AntoniRomera · 2023-12-04T17:00:58Z

@AntoniRomera can you please extract a text for such conversion of the seetings to be added to the migration guide?

Issue with the text: #594

moitabenfdz · 2023-12-04T18:07:00Z

@pedrobaeza Changed it! Thank you @AntoniRomera for the proposed changes.

pedrobaeza · 2023-12-05T07:17:52Z

Please squash the latest commit into the migration one.

AntoniRomera · 2023-12-05T13:24:20Z

@pedrobaeza I think it's more than ready now.

pedrobaeza · 2023-12-05T15:03:30Z

/ocabot merge nobump

OCA-git-bot · 2023-12-05T15:04:25Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1606-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-12-05T15:08:01Z

Congratulations, your PR was merged at 91354f0. Thanks a lot for contributing to OCA. ❤️

rousseldenis · 2024-04-09T13:52:23Z

@OCA/board @OCA/core-maintainers It seems module is merged but not published on OCA shop:

https://odoo-community.org/shop/partner-first-name-and-last-name-1794?search=partner_firstname#attr=21627

nor on Odoo apps page: https://apps.odoo.com/apps/modules/16.0/partner_firstname/

But correctly on pypi : https://pypi.org/project/odoo-addon-partner-firstname/

Could you look at ?

eLBati and others added 30 commits November 16, 2023 12:44

[ADD] partner_firstname for v8

198d975

because it's working as is

Fix pep8 (line length)

e0fae33

Fix pylint errors

Spanish translation

6769ab9

Add OCA as author of OCA addons

f4426eb

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

[FIX] partner_firstname: Better practices in views

68c35bd

[FIX] cannot create user due to required name.

26f9f3d

[ADD] Italian translation

ff6fd7e

Danish translation of partner_firstname

93934b4

[REF][partner_firstname] Method refactoring to use algorithms in othe…

18eb6e4

…r model

Add missing default oca icons

8c23d8c

[IMP][partner_firstname] Update documentation according methods refac…

99f0b20

…toring

[UPD] prefix versions with 8.0

8818853

[MIG] Make modules uninstallable

f91724f

Prepare partner_firstname for partner_second_lastname

683a7ac

Fix OCA#78. Test it too.

cee416d

Inverse values of name if required at creation.

294d72c

Allow creation of partners from *Create and Edit*.

ce5fd68

This fixes OCA#78 and adds new tests for it.

Fix bug OCA#154.

28ec3de

Conflicts: partner_firstname/__openerp__.py partner_firstname/tests/__init__.py Fix flake8 error After all, this was just a workaround. Remove it. The real fix was in OCA#171. I leave the tests. Fix test that was having sentences after return. PEP8 fix.

[FIX] _get_inverse_name in case of space in name

f008bc2

Credit creators, using same name across modules to avoid split statis…

cd1e357

…tics. Conflicts: partner_contact_gender/__openerp__.py

[FIX] remove en.po that was erroneously created by transbot

7848d7e

[MIG] Make modules uninstallable

097d198

[MIG] Rename manifest files

c303709

[MIG] Migrate partner_firstname to v10

0f6db15

[IMP] Partner names order configurable

15424ff

[FIX] partner_firstname: name, firstname and lastname only required i…

3e2fcca

…f adress 'type' is contact

dreispt approved these changes Nov 17, 2023

View reviewed changes

AntoniRomera reviewed Nov 30, 2023

View reviewed changes

partner_firstname/views/base_config_view.xml Outdated Show resolved Hide resolved

AntoniRomera approved these changes Nov 30, 2023

View reviewed changes

OCA-git-bot added the approved label Nov 30, 2023

yle-scopea suggested changes Nov 30, 2023

View reviewed changes

OCA-git-bot removed approved labels Nov 30, 2023

AntoniRomera mentioned this pull request Nov 30, 2023

[17.0][MIG] partner_second_lastname #1618

Merged

1 task

MRomeera approved these changes Dec 4, 2023

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Dec 4, 2023

moitabenfdz force-pushed the 17.0-mig-partner_firstname branch from c71665a to 4725bd6 Compare December 4, 2023 18:03

[MIG] partner_firstname: Migration to 17.0

fd3bc85

moitabenfdz force-pushed the 17.0-mig-partner_firstname branch from 4725bd6 to fd3bc85 Compare December 5, 2023 07:40

OCA-git-bot added the bot is merging ⏳ label Dec 5, 2023

OCA-git-bot merged commit 71a4b21 into OCA:17.0 Dec 5, 2023
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] partner_firstname: Migration to 17.0 #1606

[17.0][MIG] partner_firstname: Migration to 17.0 #1606

moitabenfdz commented Nov 16, 2023

AntoniRomera left a comment

yle-scopea Nov 30, 2023

AntoniRomera Nov 30, 2023

MRomeera left a comment

AntoniRomera commented Dec 4, 2023

pedrobaeza commented Dec 4, 2023

AntoniRomera commented Dec 4, 2023

pedrobaeza commented Dec 4, 2023

pedrobaeza commented Dec 4, 2023

AntoniRomera commented Dec 4, 2023

moitabenfdz commented Dec 4, 2023

pedrobaeza commented Dec 5, 2023

AntoniRomera commented Dec 5, 2023

pedrobaeza commented Dec 5, 2023

OCA-git-bot commented Dec 5, 2023

OCA-git-bot commented Dec 5, 2023

rousseldenis commented Apr 9, 2024

[17.0][MIG] partner_firstname: Migration to 17.0 #1606

[17.0][MIG] partner_firstname: Migration to 17.0 #1606

Conversation

moitabenfdz commented Nov 16, 2023

AntoniRomera left a comment

Choose a reason for hiding this comment

yle-scopea Nov 30, 2023

Choose a reason for hiding this comment

AntoniRomera Nov 30, 2023

Choose a reason for hiding this comment

MRomeera left a comment

Choose a reason for hiding this comment

AntoniRomera commented Dec 4, 2023

pedrobaeza commented Dec 4, 2023

AntoniRomera commented Dec 4, 2023

pedrobaeza commented Dec 4, 2023

pedrobaeza commented Dec 4, 2023

AntoniRomera commented Dec 4, 2023

moitabenfdz commented Dec 4, 2023

pedrobaeza commented Dec 5, 2023

AntoniRomera commented Dec 5, 2023

pedrobaeza commented Dec 5, 2023

OCA-git-bot commented Dec 5, 2023

OCA-git-bot commented Dec 5, 2023

rousseldenis commented Apr 9, 2024