Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] partner_contact_personal_information_page: Migration to version 17.0 #1608

Merged
merged 24 commits into from
Dec 3, 2023
Merged

[17.0][MIG] partner_contact_personal_information_page: Migration to version 17.0 #1608

merged 24 commits into from
Dec 3, 2023

Conversation

Daemo00
Copy link
Contributor

@Daemo00 Daemo00 commented Nov 18, 2023

No description provided.

Jairo Llopis and others added 23 commits November 18, 2023 00:55
@Daemo00
Create partner_contact_personal_information_page.
660afaf 
Really I'm just renaming partner_contact_base.
The new name is more self-explanatory.
@yvaucher @Daemo00
Add missing default oca icons
e78a09c
@sbidoul @Daemo00
prefix versions with 8.0
06f2f44
@pedrobaeza @Daemo00
Make modules uninstallable
a2f69c0
@Daemo00
partner_contact_personal_information updated to version 9.0
415128b
@leemannd @Daemo00
Remove refecence of base in xmlid
ac9af29
@pedrobaeza @Daemo00
Make modules uninstallable
630e525
@pedrobaeza @Daemo00
Rename manifest files
d029a89
@Daemo00
Migration partner_contact_birthdate partner_contact_gender part… (OCA…
6fb2e01 
…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10
@Daemo00
V11 migration
5333516 
- fax field removed from res.partner
- 2to3 on all py files
- add contributor and update README
- use hasclass in place of @Class in xpath expr
- improve tests

[FIX] typo and clean README
@hhgabelgaard @Daemo00
Added translation using Weblate (Danish)
2531f17
@Nikul-Chaudhary @Daemo00
[MIG] partner_contact_personal_information_page v11 to v12
72120bb
@Daemo00
[MIG] partner_contact_personal_information_page: Migration to 13.0
dfaa48e
@Daemo00
[13.0] run black
1b5b2f9
@Daemo00
[13.0] update readme + add S to http:// urls
80c4d5c
@newtratip @Daemo00
[MIG] partner_contact_personal_information_page: Migration to 14.0
a46516f
@tdombos @Daemo00
Added translation using Weblate (Hungarian)
7588927
@pedrocs-exo @Daemo00
Added translation using Weblate (Portuguese)
f5e2cbb
@holdenrehg @Daemo00
[UPD] partner_contact_personal_information_page: bump manifest versio…
f8badbf 
…n to 15.0.1.0.0
@juliap98 @Daemo00
Added translation using Weblate (Catalan)
0ded6a4
@marielejeune @Daemo00
[MIG] partner_contact_personal_information_page: Migration to 16.0
929ae5e
@badbole @Daemo00
Added translation using Weblate (Croatian)
0d878de
@Daemo00
[IMP] partner_contact_personal_information_page: pre-commit execution
2e732bc
@Daemo00 Daemo00 mentioned this pull request Nov 18, 2023
Open
63 tasks
@Daemo00 Daemo00 marked this pull request as ready for review November 18, 2023 00:14
@Daemo00 Daemo00 mentioned this pull request Nov 18, 2023
Merged
1 task
@pedrobaeza pedrobaeza changed the title [MIG] partner_contact_personal_information_page [17.0][MIG] partner_contact_personal_information_page: Migration to version 17.0 Nov 18, 2023
@pedrobaeza
Copy link
Member

/ocabot migration partner_contact_personal_information_page

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 18, 2023
FernandoRomera
FernandoRomera approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@FernandoRomera FernandoRomera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test in runboat, Ok.

@pedrobaeza pedrobaeza mentioned this pull request Nov 24, 2023
Closed
AntoniRomera
AntoniRomera approved these changes Nov 30, 2023
View reviewed changes
Copy link

@AntoniRomera AntoniRomera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Code Review OK

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

Please put the pre-commit auto fixes commit (before the migration one), and you can put it as maintainer in the same commit as the migration.

@Daemo00 Daemo00 force-pushed the 17.0-mig-partner_contact_personal_information_page branch from 7d60e48 to a9302a6 Compare December 3, 2023 10:48
@Daemo00
Copy link
Contributor Author

Daemo00 commented Dec 3, 2023

Thanks everyone for having a look!

Please put the pre-commit auto fixes commit (before the migration one), and you can put it as maintainer in the same commit as the migration.

There is already a commit (2e732bc) dedicated to pre-commit auto fixes before the migration commit, but maybe I have misunderstood what you are suggesting.
I have squashed the migration and adoption commits.

Let me know if anything else is needed.

etobella
etobella approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1608-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9f32934 into OCA:17.0 Dec 3, 2023
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 442a17a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoniRomera AntoniRomera AntoniRomera approved these changes

@etobella etobella etobella approved these changes

@FernandoRomera FernandoRomera FernandoRomera approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.