-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] partner_data_vies_populator #1642
base: 16.0
Are you sure you want to change the base?
Conversation
a837f35
to
8fbbfd0
Compare
6ffaf96
to
8d99650
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Ping! |
@@ -0,0 +1,2 @@ | |||
This module require the `python-stdnum <https://pypi.org/project/python-stdnum/>`_ library. | |||
As Odoo itself depends on this librairy, it should already be installed on your system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Odoo itself depends on this librairy, it should already be installed on your system. | |
As Odoo itself depends on this library, it should already be installed on your system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreispt Please attend to this?
Would like to do a func rev. Of the new feature. But runboat is not available. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@dreispt can you recreate a runboat? |
Improve error handling to avoid crash when Internet connectivity is down Read country code from VIES, not from VAT number No update when VAT number is invalid Improve tests
Currently translated at 100.0% (5 of 5 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_data_vies_populator Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_data_vies_populator/fr/
8d99650
to
96e9267
Compare
@bosd Rebased and pushed. That should make it available on Runboat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this!
Functional test:
The code for updating zip code and city name is not working for VAT numbers from the Netherlands.
Quick code review, minor grammar changes
|
||
So, when the data is retrieved, it will try to populate the *City* and *Zip* fields | ||
from the last line of the address. | ||
T he *Street* field will contain the remaining information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T he *Street* field will contain the remaining information. | |
The *Street* field will contain the remaining information. |
@@ -0,0 +1,2 @@ | |||
This module require the `python-stdnum <https://pypi.org/project/python-stdnum/>`_ library. | |||
As Odoo itself depends on this librairy, it should already be installed on your system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreispt Please attend to this?
Includes improvement: