Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][Feat] Added store location type contact #1799

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

wouitmil
Copy link

@wouitmil wouitmil commented Jul 4, 2024

Screenshot 2024-07-04 at 11 20 13

@wouitmil wouitmil force-pushed the camptocamp-publish-oca branch 3 times, most recently from 6acda54 to 77bb2ae Compare July 4, 2024 10:24
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright is missing. Please fix this.

partner_store/models/res_partner.py Show resolved Hide resolved
@wouitmil wouitmil force-pushed the camptocamp-publish-oca branch 4 times, most recently from 339c70f to ab1e1b1 Compare August 29, 2024 17:53
Copy link

@StephaneMangin StephaneMangin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@@ -0,0 +1,64 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is supposed to e generated from documents in the readme/ subdirectory but this directory is missing.

Additionally the content of the file is suspicious. I see no "geospatial support" in the module, for instance.

Copy link
Author

@wouitmil wouitmil Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better like this?

@yvaucher
Copy link
Member

yvaucher commented Sep 3, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1799-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 678193a into OCA:16.0 Sep 3, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bd67f80. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants