[FIX] [16.0] partner_contact_address_default child layout #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, strange English populated a single column on the child contact layout. After this commit, we span the 4 columns and clean up the text.
|
Enhanced PR to also resolve #1659 @pedrobaeza |
|
Please follow commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message |
|
And squash commits into one. |
|
I mean I can obviously, but it is two commits for two different issues. Anyway, I was just doing quickly on a Saturday morning, now I need to pull the repo and mess about so next week job. |
|
OK, I think they can go together, but at least put proper commit messages (without the version, with the tag, and indicating the module name). |
|
Hmm I cocked this up anyway and did directly on branch. Will just close and do properly and delete this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, strange English populated a single column on the child contact layout.
After this commit, we span the 4 columns and clean up the text.