Skip to content

Commit

Permalink
[IMP] - use display for element visibility
Browse files Browse the repository at this point in the history
the visibility attribute with the hidden option hides the element but
don't free the space.

A common use case is to have a specific header for the first page and
another for the other pages. With visibility: hidden the second header
cannot take the first one place and will keep a huge margin.
One solution is to use the display:none instead.
  • Loading branch information
sbejaoui authored and cvinh committed Dec 14, 2022
1 parent dc32616 commit 6304228
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions report_qweb_element_page_visibility/views/layouts.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@
}
var operations = {
'not-first-page': function (elt) {
elt.style.visibility = (vars.sitepage === vars.frompage) ? "hidden" : "visible";
elt.style.display = (vars.sitepage === vars.frompage) ? "none" : "inherit";
},
'not-last-page': function (elt) {
elt.style.visibility = (vars.sitepage === vars.sitepages) ? "hidden" : "visible";
elt.style.display = (vars.sitepage === vars.sitepages) ? "none" : "inherit";
},
'first-page': function (elt) {
elt.style.visibility = (vars.sitepage === vars.frompage) ? "visible" : "hidden";
elt.style.display = (vars.sitepage === vars.frompage) ? "inherit" : "none";
},
'last-page': function (elt) {
elt.style.visibility = (vars.sitepage === vars.sitepages) ? "visible" : "hidden";
elt.style.display = (vars.sitepage === vars.sitepages) ? "inherit" : "none";
},
};
for (var klass in operations) {
Expand Down

0 comments on commit 6304228

Please sign in to comment.