[15.0][FIX] base_comment_template: Fix access error #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please name properly the commit message: |
Fix an access error in the base_comment_template module in the BaseCommentTemplate.name_get() method. Add sudo() before reading ir_model.name fields to fix access error for users without admin rights when opening contact form views.
BT-pgaiser
force-pushed
the
15.0-fix_access_err_bct
branch
from
600000d
to
c938db0
Compare
|
@pedrobaeza Fixed commit message. |
pedrobaeza
changed the title
pedrobaeza
approved these changes
Jul 4, 2023
AaronHForgeFlow
approved these changes
Jul 18, 2023
|
/ocabot merge patch Please fw-port it to v16 if applicable |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 7bb4e8d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the base comment template feature on contacts (res_partner), when a user without admin rights tries to open up the form view of an affected contact, he gets an access error because he doesn't have the necessary rights to read the fields from 'ir_model'.
This adjustment fixes that.