[15.0][FIX] base_comment_template: search when multiple models in a template #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Jul 20, 2023
AaronHForgeFlow
force-pushed
the
15.0-fix-base_comment_template-model
branch
from
fa2061c
to
89e980e
Compare
pedrobaeza
approved these changes
Jul 28, 2023
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 41f3172. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have comment templates that are shared between several models:
I think the module allows to do so in the specifications and the _search_model_ids method needs to change it will output an error
@ForgeFlow