Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] report_csv: add encoding option #815

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][IMP] report_csv: add encoding option #815

wants to merge 1 commit into from

Conversation

AungKoKoLin1997
Copy link
Contributor

Recreate PR that was closed #740.

@qrtl

len-foss
len-foss approved these changes Dec 3, 2023
View reviewed changes
Copy link

@len-foss len-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gurneyalex
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

@gurneyalex The merge process could not start, because command `git merge --no-ff -m 'Merge PR #815 into 14.0

Signed-off-by gurneyalex' tmp-pr-815` failed with output:

Auto-merging report_csv/static/description/index.html
CONFLICT (content): Merge conflict in report_csv/static/description/index.html
Auto-merging report_csv/README.rst
Automatic merge failed; fix conflicts and then commit the result.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 14.0-fix-report_csv branch 2 times, most recently from efeafc5 to ecaa73f Compare January 5, 2024 07:29
@AungKoKoLin1997
Copy link
Contributor Author

@gurneyalex I fixed the conflict issue. Can you please try again?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 5, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 20, 2024
@AungKoKoLin1997
Copy link
Contributor Author

@oca/reporting-engine-maintainers
Could someone please try merging it again?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@len-foss len-foss len-foss approved these changes

@yostashiro yostashiro yostashiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AungKoKoLin1997 @gurneyalex @OCA-git-bot @yostashiro @len-foss