Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] report_substitute: Migration to 17.0 #828

Merged
merged 27 commits into from
May 23, 2024
Merged

[17.0][MIG] report_substitute: Migration to 17.0 #828

merged 27 commits into from
May 23, 2024

Conversation

lef-adhoc
Copy link

No description provided.

sbejaoui and others added 26 commits December 15, 2023 09:45
@sbejaoui @lef-adhoc
[ADD] - report substitute
80659d9 
This addon give the possibility to substitute a report action by another based on some criteria.
@sbejaoui @lef-adhoc
[ADD] - Add readme
3265bef
@sbejaoui @lef-adhoc
[ADD] - Add unit tests
f778b50
@sbejaoui @lef-adhoc
[FIX] - missing method param
6e3088c
@sbejaoui @lef-adhoc
[FIX] - prevent substitution loop
27730cf
@sbejaoui @lef-adhoc
[IMP] - manage subtitute report for multi-action
d58f68f
@sbejaoui @lef-adhoc
[IMP] - manage substitution for mail.thread message_post_with_template
08121cb
@sbejaoui @lef-adhoc
[IMP] - add unit tests
e0bc864
@sbejaoui @lef-adhoc
[FIX] - manage the case where mail.compose.message is triggered from …
b190063 
…the chatter
@sbejaoui @lef-adhoc
[FIX] - Fix typo
ec8ac32
@sbejaoui @lef-adhoc
[12.0][IMP] - Add check for substitution infinite loop
8717cf4
@oca-travis @lef-adhoc
[UPD] Update report_substitute.pot
aceed8c
@OCA-git-bot @lef-adhoc
[UPD] README.rst
fef12e2
@OCA-git-bot @lef-adhoc
[ADD] icon.png
4bbd9ae
@sbejaoui @lef-adhoc
[13.0][MIG] - report_substitute migration
e867bcd
@sbejaoui @lef-adhoc
[ADD] - add sbejaoui as maintainer for report_substitute
8dc8fc2
@matiasperalta1 @lef-adhoc
[MIG] report_substitute: Migration to 15.0
7e05567
@matiasperalta1 @lef-adhoc
[MIG] report_substitute: Migration to 16.0
7552a4b
@lef-adhoc
[UPD] Update report_substitute.pot
1f23aa5
@OCA-git-bot @lef-adhoc
[UPD] README.rst
691e937
@OCA-git-bot @lef-adhoc
[UPD] README.rst
1d749a6
@Ivorra78 @lef-adhoc
Added translation using Weblate (Spanish)
c216596
@Ivorra78 @lef-adhoc
Translated using Weblate (Spanish)
0f95305 
Currently translated at 100.0% (21 of 21 strings)

Translation: reporting-engine-16.0/reporting-engine-16.0-report_substitute
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_substitute/es/
@SodexisTeam @lef-adhoc
[FIX] report_substitute: support for email
ea75f83
@OCA-git-bot @lef-adhoc
[BOT] post-merge updates
7e10470
@lef-adhoc
[IMP] report_substitute: pre-commit auto fixes
2055777
@lef-adhoc lef-adhoc force-pushed the 17.0-mig-report_substitute branch 2 times, most recently from 2ff3cdc to 68ae4da Compare December 15, 2023 15:20
@lef-adhoc lef-adhoc mentioned this pull request Dec 15, 2023
Open
25 tasks
@lef-adhoc lef-adhoc changed the title [MIG] report_substitute: Migration to 17.0 [17.0][MIG] report_substitute: Migration to 17.0 Dec 15, 2023
@lef-adhoc
Copy link
Author

Hi @sbejaoui, may you have check this ?
Thank you

sbejaoui
sbejaoui approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review

atchuthan
atchuthan suggested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@atchuthan atchuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changes available in adhoc-dev#1

Code migration is not complete when we used the initial commit, we made corrections and sent PR.

matiasperalta1
matiasperalta1 reviewed Apr 15, 2024
View reviewed changes
report_substitute/models/mail_thread.py Outdated
class MailThread(models.AbstractModel):
_inherit = "mail.thread"

def message_post_with_template(self, template_id, **kwargs):
Copy link
Contributor

@matiasperalta1 matiasperalta1 Apr 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Este método cambió
ahora es message_post_with_source
ver en este commit (odoo/odoo@4775bd9)

atchuthan
atchuthan approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@atchuthan atchuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sakthi-shan
Copy link

@sbejaoui can we get this merged?

@sakthi-shan
Copy link

@lef-adhoc
DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, report_substitute can just have a UTF8 description with not need for a declaration.
We are getting this Warning in the log with the latest code. Please make the changes.

@lef-adhoc lef-adhoc force-pushed the 17.0-mig-report_substitute branch from 633f9ba to 156ccf0 Compare May 8, 2024 14:27
SodexisTeam
SodexisTeam suggested changes May 13, 2024
View reviewed changes
report_substitute/models/mail_thread.py Outdated
):
template, view = self._get_source_from_ref(source_ref)
old_report_template_ids = False
if template.report_template_ids and self.ids:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting this error, when template is false.

  File "/opt/odoo/sodtest17-odoo/src/community_modules_links/report_substitute/models/mail_thread.py", line 21, in message_post_with_source
    if template.report_template_ids and self.ids:
AttributeError: 'bool' object has no attribute 'report_template_ids'

@lef-adhoc
Copy link
Author

@SodexisTeam Could you check if it is ok now?

SodexisTeam
SodexisTeam approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@SodexisTeam SodexisTeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it looks good 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@atchuthan
Copy link
Member

@OCA/reporting-engine-maintainers can we merge this PR?

@HviorForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-828-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 62ebaff into OCA:17.0 May 23, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at eb60a15. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasperalta1 matiasperalta1 matiasperalta1 left review comments

@SodexisTeam SodexisTeam SodexisTeam approved these changes

@sbejaoui sbejaoui sbejaoui approved these changes

@atchuthan atchuthan atchuthan approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@lef-adhoc @OCA-git-bot @sakthi-shan @atchuthan @HviorForgeFlow @sbejaoui @SodexisTeam @matiasperalta1 @oca-travis @Ivorra78