Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] report_async: Migration to 17.0 #878

Merged
merged 25 commits into from
Oct 1, 2024
Merged

[17.0][MIG] report_async: Migration to 17.0 #878

merged 25 commits into from
Oct 1, 2024

Conversation

sakthi-shan
Copy link

@sakthi-shan sakthi-shan mentioned this pull request May 10, 2024
Open
25 tasks
kittiu and others added 24 commits June 11, 2024 10:46
@kittiu @atchuthan
report_async
323ac96
@oca-travis @atchuthan
Update report_async.pot
11d78e9
@OCA-git-bot @atchuthan
README.rst
9864110
@OCA-git-bot @atchuthan
report_async 12.0.1.0.1
b053fec
@pedrocs-exo @atchuthan
Added translation using Weblate (Portuguese)
8615c44
@pedrocs-exo @atchuthan
Translated using Weblate (Portuguese)
c8d6f61 
Currently translated at 100.0% (51 of 51 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-report_async
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_async/pt/
@newtratip @atchuthan
report_async: black, isort, prettier
d6704c0
@newtratip @atchuthan
report_async
bf78614
@atchuthan
Update report_async.pot
4b62cdd
@OCA-git-bot @atchuthan
README.rst
34f6828
@Hardik-OSI @atchuthan
report_async: Pre-Commit
e62e49d
@Hardik-OSI @atchuthan
report_async: migration to 15.0
59a1749
@atchuthan
Update report_async.pot
7a4c3da
@OCA-git-bot @atchuthan
README.rst
a3d9b7f
@Nikul-OSI @atchuthan
[MIG] report_async: Migrated v15 to v16
6c9ffdc
@atchuthan
[UPD] Update report_async.pot
6c3d16d
@OCA-git-bot @atchuthan
[UPD] README.rst
50d8eed
@Ivorra78 @atchuthan
Added translation using Weblate (Spanish)
14243c4
@Ivorra78 @atchuthan
Translated using Weblate (Spanish)
8219ac7 
Currently translated at 100.0% (53 of 53 strings)

Translation: reporting-engine-16.0/reporting-engine-16.0-report_async
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_async/es/
@OCA-git-bot @atchuthan
[UPD] README.rst
bc34480
@weblate @atchuthan
Update translation files
232ea9e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-16.0/reporting-engine-16.0-report_async
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_async/
@mymage @atchuthan
Added translation using Weblate (Italian)
3a33983
@mymage @atchuthan
Translated using Weblate (Italian)
ae6b4cc 
Currently translated at 100.0% (53 of 53 strings)

Translation: reporting-engine-16.0/reporting-engine-16.0-report_async
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_async/it/
@sakthi-shan @atchuthan
[IMP] report_async: pre-commit auto fixes
21310d5
amkarthik
amkarthik approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@amkarthik amkarthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍🏾

@mpascuall
Copy link

Hi! Could you fix the pr name? the correct one would be [MIG] report_async: Migration to 17.0

@sakthi-shan sakthi-shan changed the title [MIG] report async: Migration to 17.0 [MIG] report_async: Migration to 17.0 Sep 18, 2024
@ppyczko
Copy link

ppyczko commented Sep 18, 2024

Hi @sakthi-shan, code looks good. Can you please rebase to rerun the runboat? As it is pending and we can't test the functionality without it, thank you in advance!

@mpascuall
Copy link

My bad, correct pr name would be [17.0][MIG] report_async: Migration to 17.0
Sorry!

@sakthi-shan sakthi-shan changed the title [MIG] report_async: Migration to 17.0 [17.0][MIG] report_async: Migration to 17.0 Sep 18, 2024
ppyczko
ppyczko approved these changes Sep 18, 2024
View reviewed changes
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally and works great!

mpascuall
mpascuall approved these changes Sep 18, 2024
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in local odoo and it works

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sakthi-shan
Copy link
Author

@kittiu

@kittiu
Copy link
Member

kittiu commented Sep 26, 2024

@kittiu

Sorry I do not have merge right.

@sakthi-shan
Copy link
Author

@OCA/reporting-engine-maintainers

@HviorForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-878-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 09578b8 into OCA:17.0 Oct 1, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5379649. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppyczko ppyczko ppyczko approved these changes

@mpascuall mpascuall mpascuall approved these changes

@amkarthik amkarthik amkarthik approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.