Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16] sql_export : Add last_run datetime field #880

Merged
merged 2 commits into from
Jun 17, 2024
Merged

[16] sql_export : Add last_run datetime field #880

merged 2 commits into from
Jun 17, 2024

Conversation

florian-dacosta
Copy link
Contributor

Very small addition, which can become quite usefull when there are hundreds of queries and some may not be used anymore.
In case of migration for instance, it may allow to priorize which should be migrated or not, etc...

@legalsylvain

@florian-dacosta
[IMP] sql_export : Add last_run datetime field
dd7cfc7 
This may be quite usefull to detect osbolete queries not used anymore in order to remove it
@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

legalsylvain
legalsylvain reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Could you add it also in the form viewsql_export_view_form ?

legalsylvain
legalsylvain requested changes May 16, 2024
View reviewed changes
sql_export/wizard/wizard_file.py Outdated Show resolved Hide resolved
@florian-dacosta
Copy link
Contributor Author

Hi. Could you add it also in the form viewsql_export_view_form ?

It does not seem necessary to me. I think it is more something you want on tree view to filter, order, and have a global vision rather than have this information on the form.
I guess we could put it on form view too, but there are no obvious place to put it either. The first group container exclusively configuration fields and the different tab are not adequate.
The cleaner way would maybe to add one more tab for these 2 information, if you insist, but on my side I don't think we need it.

legalsylvain
legalsylvain approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

bguillot
bguillot approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@bguillot bguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@legalsylvain
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-880-by-legalsylvain-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 17, 2024
@OCA-git-bot
Merge PR #880 into 16.0
5a00925 
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-880-by-legalsylvain-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9f34f48 into OCA:16.0 Jun 17, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c6e6b9e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bguillot bguillot bguillot approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florian-dacosta @OCA-git-bot @legalsylvain @bguillot