From dd7cfc726779581821e49725d51fdaab5249d919 Mon Sep 17 00:00:00 2001
From: Florian da Costa <florian.dacosta@akretion.com>
Date: Thu, 16 May 2024 18:09:59 +0200
Subject: [PATCH 1/2] [IMP] sql_export : Add last_run datetime field This may
 be quite usefull to detect osbolete queries not used anymore in order to
 remove it

---
 sql_export/models/sql_export.py      | 1 +
 sql_export/views/sql_export_view.xml | 1 +
 sql_export/wizard/wizard_file.py     | 1 +
 3 files changed, 3 insertions(+)

diff --git a/sql_export/models/sql_export.py b/sql_export/models/sql_export.py
index 3b03afa3db..1285db12b2 100644
--- a/sql_export/models/sql_export.py
+++ b/sql_export/models/sql_export.py
@@ -19,6 +19,7 @@ class SqlExport(models.Model):
 
     use_properties = fields.Boolean(compute="_compute_use_properties")
     query_properties_definition = fields.PropertiesDefinition("Query Properties")
+    last_run = fields.Datetime()
 
     encoding = fields.Selection(
         [
diff --git a/sql_export/views/sql_export_view.xml b/sql_export/views/sql_export_view.xml
index 8965843d10..7d1da59195 100644
--- a/sql_export/views/sql_export_view.xml
+++ b/sql_export/views/sql_export_view.xml
@@ -72,6 +72,7 @@
         <field name="mode">primary</field>
         <field name="arch" type="xml">
             <field name="state" position="after">
+                <field name="last_run" />
                 <button
                     name="export_sql_query"
                     string="Execute Query"
diff --git a/sql_export/wizard/wizard_file.py b/sql_export/wizard/wizard_file.py
index 69aa9c39a4..8d70b3080d 100644
--- a/sql_export/wizard/wizard_file.py
+++ b/sql_export/wizard/wizard_file.py
@@ -63,6 +63,7 @@ def export_sql(self):
                 % {"name": sql_export.name, "date": date, "extension": extension},
             }
         )
+        sql_export.write({"last_run": fields.Datetime.now()})
         action = {
             "name": "SQL Export",
             "type": "ir.actions.act_url",

From c23d9e1f455d9b2a7f8b54b892fe5a68080f1857 Mon Sep 17 00:00:00 2001
From: Florian da Costa <florian.dacosta@akretion.com>
Date: Fri, 17 May 2024 13:05:55 +0200
Subject: [PATCH 2/2] [IMP] Add last_execution_uid field + bypass orm to avoid
 impactif sql.export write_date/uid on query execution

---
 sql_export/models/sql_export.py      |  5 ++++-
 sql_export/views/sql_export_view.xml |  3 ++-
 sql_export/wizard/wizard_file.py     | 16 +++++++++++++++-
 3 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/sql_export/models/sql_export.py b/sql_export/models/sql_export.py
index 1285db12b2..d9a8a9395f 100644
--- a/sql_export/models/sql_export.py
+++ b/sql_export/models/sql_export.py
@@ -19,7 +19,10 @@ class SqlExport(models.Model):
 
     use_properties = fields.Boolean(compute="_compute_use_properties")
     query_properties_definition = fields.PropertiesDefinition("Query Properties")
-    last_run = fields.Datetime()
+    last_execution_date = fields.Datetime(readonly=True)
+    last_execution_uid = fields.Many2one(
+        "res.users", string="Last execution User", readonly=True
+    )
 
     encoding = fields.Selection(
         [
diff --git a/sql_export/views/sql_export_view.xml b/sql_export/views/sql_export_view.xml
index 7d1da59195..f377a6daff 100644
--- a/sql_export/views/sql_export_view.xml
+++ b/sql_export/views/sql_export_view.xml
@@ -72,7 +72,8 @@
         <field name="mode">primary</field>
         <field name="arch" type="xml">
             <field name="state" position="after">
-                <field name="last_run" />
+                <field name="last_execution_date" optional="hide" />
+                <field name="last_execution_uid" optional="hide" />
                 <button
                     name="export_sql_query"
                     string="Execute Query"
diff --git a/sql_export/wizard/wizard_file.py b/sql_export/wizard/wizard_file.py
index 8d70b3080d..284c1d0650 100644
--- a/sql_export/wizard/wizard_file.py
+++ b/sql_export/wizard/wizard_file.py
@@ -63,7 +63,21 @@ def export_sql(self):
                 % {"name": sql_export.name, "date": date, "extension": extension},
             }
         )
-        sql_export.write({"last_run": fields.Datetime.now()})
+        # Bypass ORM to avoid changing the write_date/uid from sql query on a simple
+        # execution. This also avoid error if user has no update right on the
+        # sql.export object.
+        self.env.cr.execute(
+            """
+            UPDATE sql_export
+            SET last_execution_date = %s, last_execution_uid = %s
+            WHERE id = %s
+        """,
+            (
+                fields.Datetime.to_string(fields.Datetime.now()),
+                self.env.user.id,
+                sql_export.id,
+            ),
+        )
         action = {
             "name": "SQL Export",
             "type": "ir.actions.act_url",