Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][IMP]bi_sql_editor: add parent menu as an editable parameter when creating UI elements #891

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[13.0][IMP]bi_sql_editor: add parent menu as an editable parameter when creating UI elements #891

merged 1 commit into from
Jun 4, 2024

Conversation

GuillemCForgeFlow
Copy link
Contributor

@GuillemCForgeFlow GuillemCForgeFlow commented Jun 4, 2024 •
edited
Loading

When creating the UI for the SQL view, it is now possible to set a specific Parent Menu which will be used when creating the UI Menu for the report itself. The default value will be the SQL Reports menu.
Also, added the explanation on the CONFIGURE.rst file to have the description updated.

cc @ForgeFlow

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-imp-bi_sql_editor-parent_menu_override branch from e247382 to 7af7750 Compare June 4, 2024 08:54
LoisRForgeFlow
LoisRForgeFlow approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea for usability

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-imp-bi_sql_editor-parent_menu_override branch 2 times, most recently from 5fc2608 to 8c1cbd6 Compare June 4, 2024 09:21
@GuillemCForgeFlow
Copy link
Contributor Author

@LoisRForgeFlow FYI just pushed some improvements here:

  • Add explanation on the CONFIGURE.rst file to have it updated based on the new change.
  • Assigned the Parent Menu when creating the UI Menu to have it always assigned based on the current Parent.

legalsylvain
legalsylvain requested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remark inline.

Otherwise, Nice improvment !

Thanks !

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-imp-bi_sql_editor-parent_menu_override branch from 8c1cbd6 to 48f9360 Compare June 4, 2024 11:05
@GuillemCForgeFlow GuillemCForgeFlow changed the title [13.0][IMP]bi_sql_editor: override parent menu with editable parameter [13.0][IMP]bi_sql_editor: add parent menu as an editable parameter when creating UI elements Jun 4, 2024
@GuillemCForgeFlow
Copy link
Contributor Author

Some minor remark inline.

Otherwise, Nice improvment !

Thanks !

Just applied the changes you were suggesting + made the field required so that we don't have possible errors when creating the UI elements. 👍🏿

@GuillemCForgeFlow
[IMP]bi_sql_editor: add parent menu as an editable parameter when cre…
27c3086 
…ating UI elements

When creating the UI for the SQL view, it is now possible to set a specific Parent Menu which will be used when creating the UI Menu for the report itself. The default value will be the `SQL Reports` menu.
Also, added the explanation on the `CONFIGURE.rst` file to have the description updated.
@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-imp-bi_sql_editor-parent_menu_override branch from 48f9360 to 27c3086 Compare June 4, 2024 11:13
legalsylvain
legalsylvain approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution !

/ocabot merge minor

hum... I'd like to have some @robodoo r+ command to propagate that improvment on 14.0 / 15.0 / 16.0 / 17.0 ...

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-891-by-legalsylvain-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cd6fb86 into OCA:13.0 Jun 4, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 017688f. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 13.0-imp-bi_sql_editor-parent_menu_override branch June 4, 2024 12:16
@MiquelRForgeFlow
Copy link
Contributor

hum... I'd like to have some @robodoo r+ command to propagate that improvment on 14.0 / 15.0 / 16.0 / 17.0 ...

Don't worry, @GuillemCForgeFlow is a good person I am sure he will do it 🙂

@GuillemCForgeFlow
Copy link
Contributor Author

hum... I'd like to have some @robodoo r+ command to propagate that improvment on 14.0 / 15.0 / 16.0 / 17.0 ...

Don't worry, @GuillemCForgeFlow is a good person I am sure he will do it 🙂

Not sure about the first thing 🙂, but for sure about forward porting the changes, I can substitute the command this time 👍🏿

This was referenced Jun 6, 2024
Merged
Merged
Merged
@GuillemCForgeFlow GuillemCForgeFlow mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillemCForgeFlow @OCA-git-bot @MiquelRForgeFlow @legalsylvain @LoisRForgeFlow @JordiMForgeFlow