Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] [16.0] report_display_name_in_footer #897

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Jun 13, 2024

Adds document name in report PDF footers.

Can configured via parameteres (see CONFIGURE.md)

MT-5999 @moduon @yajo @rafaelbn @EmilioPascual @fcvalgar @Gelojr please review if you want :)

@Shide Shide force-pushed the 16.0-report_display_name_in_footer branch from a36a15d to 718b320 Compare June 13, 2024 11:23
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review,

LGTM Thank you @Shide

image

image

image

Copy link

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Functional review

@rafaelbn
Copy link
Member

Hello @HviorForgeFlow @lmignon @alexis-via ,

Please, could you review this PR 🙏🏼 ! is easy, intelligent and simple! 😄

Thank you! ❤️

Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful module! Very good solution to the problem.
It would be nice to have an option per report, in stock.picking you have several reports. Maybe in a future module.

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. LGTM (code review)

@lmignon
Copy link
Contributor

lmignon commented Jun 14, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-897-by-lmignon-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 16d37fb into OCA:16.0 Jun 14, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0335d02. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 16.0-report_display_name_in_footer branch June 14, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants