Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] base_comment_template: script pre-migration #902

Merged

Conversation

EmilioPascual
Copy link
Contributor

@EmilioPascual EmilioPascual commented Jun 24, 2024

When upgrade odoo from old version, table base_comment_template_ir_model_rel does not exists.

MT-6161 @moduon

@EmilioPascual EmilioPascual force-pushed the 16.0-base_comment_template-fix_script_premig branch from 5b586e4 to 4f6a73b Compare June 24, 2024 07:12
Copy link
Member

@edlopen edlopen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the changes suggested by @yajo

When upgrade odoo from old version, table `base_comment_template_ir_model_rel` does not exists.

MT-6161 @moduon
@EmilioPascual EmilioPascual force-pushed the 16.0-base_comment_template-fix_script_premig branch from 4f6a73b to e6bdc32 Compare June 24, 2024 08:09
@EmilioPascual EmilioPascual requested a review from yajo June 24, 2024 08:11
@EmilioPascual
Copy link
Contributor Author

@yajo can you review again please? Thanks.

@yajo
Copy link
Member

yajo commented Jul 22, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-902-by-yajo-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d4dce16 into OCA:16.0 Jul 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ed29bd1. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-base_comment_template-fix_script_premig branch July 25, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants