[17.0][IMP]bi_sql_editor: scheduled action periodicity settings #903
Conversation
refactor `Action Settings` page to have all settings, renamed to `Settings`. Added the settings to be able to customize the periodicity of the Scheduled Action that will refresh the Materialized view.
|
Hi @legalsylvain, |
|
Hi @legalsylvain, I'd like to get your input on this whenever you have some time |
|
Hi @GuillemCForgeFlow. Thanks for contributing. |
Sure, the use case for this is that the periodicity of the refresh was too low. It could be changed at Scheduled Action level, but each time the view gets recreated (because the SQL definition changes) the Scheduled Action gets back to the original parameters. I thought it would be great to have a general settings tab, in order to fulfill this kind of information if it needs to be changed based on specific needs. We can add more settings' groups on that tab if required in the future. What do you think? |
Based on changes done in: OCA#903
Based on changes done in: OCA#903
Based on changes done in: OCA#903
There was a problem hiding this comment.
but each time the view gets recreated (because the SQL definition changes) the Scheduled Action gets back to the original parameters
You're right. That's the point. It should be changed, for exemple, disabling the cron instead of deleting it. What do you think ?
It avoid to duplicate fields in both modèls.
I agree, that seems to solve the issue for both of us. I will adjust the changes then to have this in place. Thank you for the input 😄 |
|
closing, I will reference the implemented solution once done 👍🏿 @legalsylvain |
…etting the SQL View Based on the agreed solution: OCA#903 (review). It is best to archive the Scheduled Action every time you set back to the draft state. Then, when creating the SQL view, if it is a materialized view, unarchive the Scheduled Action if already exists, otherwise create it from scratch.
|
Implemented agreed changes on #928 |
GuillemCForgeFlow
deleted the
17.0-imp-bi_sql_editor-add_ir_cron_periodicity_settings
branch
…etting the SQL View Based on the agreed solution: OCA#903 (review). It is best to archive the Scheduled Action every time you set back to the draft state. Then, when creating the SQL view, if it is a materialized view, unarchive the Scheduled Action if already exists, otherwise create it from scratch. Then, if the SQL View is deleted, also make sure to remove the Scheduled Action if there is one assigned as it has not been done in the `button_set_draft` method
…etting the SQL View Based on the agreed solution: OCA#903 (review). It is best to archive the Scheduled Action every time you set back to the draft state. Then, when creating the SQL view, if it is a materialized view, unarchive the Scheduled Action if already exists, otherwise create it from scratch. Then, if the SQL View is deleted, also make sure to remove the Scheduled Action if there is one assigned as it has not been done in the `button_set_draft` method
refactor
Action Settingspage to have all settings, renamed toSettings. Added the settings to be able to customize the periodicity of the Scheduled Action that will refresh the Materialized view.cc @ForgeFlow