[12.0][IMP] report_async: add schedule_date field #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kittiu, |
RicardCForgeFlow
force-pushed
the
12.0-imp-report_async-schedule_time
branch
from
38a1f45
to
235305e
Compare
RicardCForgeFlow
changed the title
RicardCForgeFlow
force-pushed
the
12.0-imp-report_async-schedule_time
branch
2 times, most recently
from
84877c7
to
9492918
Compare
RicardCForgeFlow
force-pushed
the
12.0-imp-report_async-schedule_time
branch
from
9492918
to
f98265e
Compare
HviorForgeFlow
approved these changes
Jul 3, 2024
MiquelRForgeFlow
suggested changes
Jul 3, 2024
report_async/models/report_async.py
Outdated
| @@ -71,7 +70,7 @@ class ReportAsync(models.Model): | |||
| help="List all files created by this report background process", | |||
| ) | |||
|
|
|||
| schedule_time = fields.Char(string='Schedule time') | |||
| schedule_time = fields.Datetime(string='Schedule Time') | |||
There was a problem hiding this comment.
This would need migration scripts. Can we adapt the code in a way to avoid this change?
RicardCForgeFlow
force-pushed
the
12.0-imp-report_async-schedule_time
branch
from
7993419
to
27e4d3b
Compare
MiquelRForgeFlow
approved these changes
Jul 3, 2024
RicardCForgeFlow
changed the title
|
This PR has the |
|
/ocabot merge major |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 675d7ec. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change schedule_time to Datetime field
@ForgeFlow