Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] add module to remove app download links #72

Merged
merged 1 commit into from
Jul 6, 2023
Merged

[14.0][ADD] add module to remove app download links #72

merged 1 commit into from
Jul 6, 2023

Conversation

PicchiSeba
Copy link

@PicchiSeba PicchiSeba commented Mar 27, 2023 •
edited
Loading

Proposal for a module to disable the Odoo Enterprise app download window when no expenses have been registered

Before:
Screenshot from 2023-03-27 15-54-24

After:
Screenshot from 2023-03-27 15-52-48

I think this could be an interesting addition to the de-brand options.
This module only depends on the hr_expense module, which is also the reason why it wasn't included in previously available de-brand modules.

@PicchiSeba PicchiSeba force-pushed the 14.0-add_module_remove_app_links branch from 2447332 to d78be1b Compare March 27, 2023 14:02
@PicchiSeba
Copy link
Author

pre-commit error doesn't seem to be related to my changes, can anyone confirm?

astirpe
astirpe suggested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me that the pre-commit failure is unrelated to this PR

remove_mobile_app_links/views/hr_expense.xml Outdated Show resolved Hide resolved
remove_mobile_app_links/__manifest__.py Outdated Show resolved Hide resolved
@PicchiSeba PicchiSeba force-pushed the 14.0-add_module_remove_app_links branch from d78be1b to f2a1ac2 Compare March 28, 2023 11:04
@PicchiSeba
Copy link
Author

PicchiSeba commented Mar 28, 2023 •
edited
Loading

I applied the suggested fixes but the error seems to be the same as before. I guess we'll have to wait.

@PicchiSeba PicchiSeba force-pushed the 14.0-add_module_remove_app_links branch from f2a1ac2 to 9cfe944 Compare March 28, 2023 14:19
@PicchiSeba PicchiSeba changed the title [14.0][IMP] add module to remove app download links [14.0][ADD] add module to remove app download links Mar 28, 2023
@PicchiSeba PicchiSeba force-pushed the 14.0-add_module_remove_app_links branch from 9cfe944 to 44eb690 Compare March 28, 2023 14:33
astirpe
astirpe approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review is ok for me.
I don't know if the module should renamed in order to mention that it extends hr_expense (something like remove_expense_mobile_app_link, but I would let someone else discuss/decide.
So I approve the module as it is.

@aleuffre
Copy link

aleuffre commented Jul 6, 2023 •
edited
Loading

I agree with the rename to hr_expense_remove_mobile_link

Otherwise, looks good!

Will approve after the name change.

@PicchiSeba PicchiSeba force-pushed the 14.0-add_module_remove_app_links branch from 44eb690 to 0cf78aa Compare July 6, 2023 08:18
@PicchiSeba PicchiSeba marked this pull request as draft July 6, 2023 08:20
@PicchiSeba PicchiSeba force-pushed the 14.0-add_module_remove_app_links branch from 0cf78aa to 2157f30 Compare July 6, 2023 08:26
@PicchiSeba PicchiSeba marked this pull request as ready for review July 6, 2023 08:26
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@aleuffre
Copy link

aleuffre commented Jul 6, 2023

@OCA/brand-maintainers

@thomaspaulb
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-72-by-thomaspaulb-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 627aaa4 into OCA:14.0 Jul 6, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e9df384. Thanks a lot for contributing to OCA. ❤️

@astirpe
Copy link
Member

astirpe commented Jul 6, 2023

@PicchiSeba will you also port this module to V15 and V16?

@aleuffre aleuffre deleted the 14.0-add_module_remove_app_links branch July 6, 2023 12:14
@PicchiSeba
Copy link
Author

@astirpe
Yes

@aleuffre aleuffre mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HviorForgeFlow HviorForgeFlow HviorForgeFlow left review comments

@aleuffre aleuffre aleuffre approved these changes

@astirpe astirpe astirpe approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PicchiSeba @aleuffre @OCA-git-bot @thomaspaulb @astirpe @HviorForgeFlow