Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] attachment_db_by_checksum #239

Merged
merged 6 commits into from
Oct 19, 2023

Conversation

SirTakobi
Copy link

Third attempt to share this module with the OCA ecosystem, after the previous attempts have gone stale:

  1. for 10.0: [10.0] attachment_db_by_checksum #109
  2. for 12.0: [12.0] ADD attachment_db_by_checksum #107

Here I am preserving the history of #107 (following https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0), and have added a few goodies:

  • refactoring
  • improved documentation (method docstrings)
  • tests 🎉
  • fix a particular use-case (see the [FIX] commit for more details)

Hoping the third time's a charm 🍀

@SirTakobi SirTakobi marked this pull request as ready for review February 15, 2023 11:15
@SirTakobi
Copy link
Author

Is any of the previous reviewers still interested? @gurneyalex @simahawk
cc @eLBati

Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SirTakobi
Copy link
Author

@OCA/storage-maintainers maybe someone is interested in this module?

@SirTakobi SirTakobi force-pushed the 14.0-mig-attachment_db_by_checksum branch from fd7203c to 5e02901 Compare August 17, 2023 16:21
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is used in prod since a while now, right? :)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hparfr
Copy link
Contributor

hparfr commented Oct 19, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-239-by-hparfr-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b4214bc into OCA:14.0 Oct 19, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 22f11fc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants