Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] fs_base_multi_image + fs_product_multi_image: Migration to 17.0 #351

Closed
wants to merge 58 commits into from
Closed

[17.0][MIG] fs_base_multi_image + fs_product_multi_image: Migration to 17.0 #351

wants to merge 58 commits into from

Conversation

nguyenminhchien
Copy link

@nguyenminhchien nguyenminhchien commented Mar 8, 2024 •
edited
Loading

@nguyenminhchien nguyenminhchien marked this pull request as ready for review March 8, 2024 09:40
This was referenced Mar 8, 2024
Open
Merged
@lmignon
Copy link
Contributor

lmignon commented Mar 24, 2024

/ocabot migration fs_base_multi_image

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Mar 24, 2024
@lmignon
Copy link
Contributor

lmignon commented Mar 24, 2024

/ocabot migration fs_product_multi_image

lmignon
lmignon approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the migration!

@lmignon
Copy link
Contributor

lmignon commented Apr 25, 2024

@nguyenminhchien Can you rebase and remove test dependency on merged PR plz? Thank you.

lmignon and others added 20 commits April 26, 2024 09:35
@lmignon @nguyenminhchien
[ADD] fs_product_multi_image: a drop-in replacement of storage_image_…
d0891df 
…product
@nguyenminhchien
[UPD] Update fs_base_multi_image.pot
792d774
@OCA-git-bot @nguyenminhchien
[BOT] post-merge updates
7780de6
@Ivorra78 @nguyenminhchien
Added translation using Weblate (Spanish)
9302cda
@Ivorra78 @nguyenminhchien
Translated using Weblate (Spanish)
0f02e4e 
Currently translated at 100.0% (25 of 25 strings)

Translation: storage-16.0/storage-16.0-fs_base_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/es/
@mymage @nguyenminhchien
Added translation using Weblate (Italian)
6127d37
@mymage @nguyenminhchien
Translated using Weblate (Italian)
26da00d 
Currently translated at 100.0% (25 of 25 strings)

Translation: storage-16.0/storage-16.0-fs_base_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/it/
@benwillig @nguyenminhchien
[FIX] updated image and image_medium label to prevent odoo warning wi…
0ca89e2 
…th same label for image/image_1920 and image_medium/image_128 for product.template and product.product
@nguyenminhchien
[UPD] Update fs_base_multi_image.pot
d18c379
@OCA-git-bot @nguyenminhchien
[BOT] post-merge updates
e0bd96c
@weblate @nguyenminhchien
Update translation files
5a697c2 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: storage-16.0/storage-16.0-fs_base_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/
@mymage @nguyenminhchien
Translated using Weblate (Italian)
3f58af0 
Currently translated at 100.0% (26 of 26 strings)

Translation: storage-16.0/storage-16.0-fs_base_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/it/
@benwillig @nguyenminhchien
[FIX] Creating new relation records in the UI with link_existing trig…
758ca2f 
…ger the inverse method, which results in a ValueError
@benwillig @nguyenminhchien
[ADD] new widget to allow image upload through drag and drop or file …
e824bbb 
…selection
@benwillig @nguyenminhchien
[ADD] allow user to select where he want to store the image
c7fa674
@benwillig @nguyenminhchien
[IMP] block the UI during the upload
181740e
@nguyenminhchien
[UPD] Update fs_base_multi_image.pot
97b6591
@OCA-git-bot @nguyenminhchien
[BOT] post-merge updates
836f7ef
@weblate @nguyenminhchien
Update translation files
bbef786 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: storage-16.0/storage-16.0-fs_base_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/
@Ivorra78 @nguyenminhchien
Translated using Weblate (Spanish)
98a75fc 
Currently translated at 100.0% (32 of 32 strings)

Translation: storage-16.0/storage-16.0-fs_base_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_image/es/
benwillig and others added 12 commits April 26, 2024 09:35
@benwillig @nguyenminhchien
[ADD] allow user to select where he want to store the image
017a412
@nguyenminhchien
[UPD] Update fs_product_multi_image.pot
af7f5ac
@OCA-git-bot @nguyenminhchien
[BOT] post-merge updates
9068517
@weblate @nguyenminhchien
Update translation files
b95e21f 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/
@Ivorra78 @nguyenminhchien
Translated using Weblate (Spanish)
e4cb075 
Currently translated at 100.0% (34 of 34 strings)

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/es/
@benwillig @nguyenminhchien
[FIX] do not display kanban img tag if the record has not been create…
07ab3fc 
… or there will be an owl error
@benwillig @nguyenminhchien
Added translation using Weblate (French)
ffa564d
@benwillig @nguyenminhchien
Translated using Weblate (French)
38247d5 
Currently translated at 76.4% (26 of 34 strings)

Translation: storage-16.0/storage-16.0-fs_product_multi_image
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/fr/
@OCA-git-bot @nguyenminhchien
[BOT] post-merge updates
90747cc
@nguyenminhchien
[IMP] fs_product_multi_image: pre-commit auto fixes
9ca3aa2
@nguyenminhchien
[MIG] fs_base_multi_image: Migration to 17.0
f7d0410
@nguyenminhchien
[MIG] fs_product_multi_image: Migration to 17.0
2425b68
@nguyenminhchien
Copy link
Author

@nguyenminhchien Can you rebase and remove test dependency on merged PR plz? Thank you.

Hi, updated.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

2 similar comments
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented May 2, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-351-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 2, 2024
@OCA-git-bot
Merge PR #351 into 17.0
5cab5b7 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-351-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-351-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt dreispt added help wanted Extra attention is needed needs fixing labels May 2, 2024
@dreispt dreispt mentioned this pull request May 3, 2024
Merged
@dreispt
Copy link
Member

dreispt commented May 3, 2024

Attempting merge with #369

@dreispt dreispt closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved help wanted Extra attention is needed needs fixing ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
9 participants
@nguyenminhchien @lmignon @OCA-git-bot @dreispt @gurneyalex @Ivorra78 @mymage @benwillig @weblate