[16.0] fs_attachment: sent the mimetype information for S3 #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lmignon, |
sebastienbeau
changed the title
FranzPoize
force-pushed
the
16.0-s3-mimetype
branch
from
8bd8d77
to
1ec3326
Compare
|
Cherry picked in 17.0 to test with a local minio, mimetype is now correctly set. |
lmignon
requested changes
Jun 26, 2024
Comment on lines
+387
to
+389
| if hasattr(fs.fs, "s3"): | ||
| # For S3 storage the mimetype should be pass in the kwargs | ||
| return {"ContentType": self._context["mimetype"]} |
There was a problem hiding this comment.
the s3 fs could be nested at a deeper level... IMO you should recursively test the nested fs. Something like:
_fs = fs
while _fs:
if hasattr(_fs, "s3"):
return {"ContentType": self._context["mimetype"]}
_fs = getattr(_fs, "fs", None)
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
superseded by #378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When storing image on amazon s3, ovh or scaleway.
The minetype must be set in order to have the right mimetype when requesting the image publicly.
Note : when using the api put_file it will guess the mimetype automatically : https://github.com/fsspec/s3fs/blob/47ffcfad33f8c74974a1515cb266168ede6cf4b5/s3fs/core.py#L1176