[16.0][FIX] fs_attachment: respect controller parameters for /web/content/ #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lmignon, |
|
Thank you for the fix @hbrunn Can you I a unittest to check that it works in the initial case and with fs_attachment? |
hbrunn
force-pushed
the
16.0-fs_attachment-_get_stream_from
branch
from
902ae9a
to
d0c9fa8
Compare
|
/ocabot rebase |
|
Congratulations, PR rebased to 16.0. |
OCA-git-bot
force-pushed
the
16.0-fs_attachment-_get_stream_from
branch
from
d0c9fa8
to
8d52fb0
Compare
lmignon
approved these changes
May 6, 2024
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at f4a2829. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we craft a link like
/web/content?model=my.model&filename_field=filename&field=binary_field&mimetype=mime.type&filename=myfile.namethe parameters are ignored and the resulting download gets the generic (wrong) name/mimetype from the attachment of the binary field if it is of type
fs. For filestore attachments, this happens inir.binary#_get_stream_from, so I think we need to do the same thing for fs attachments. Otherwise, we can't really use this as drop-in replacement for storing binary fields in object storage.