Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][IMP] fs_attachment: send the mimetype information for S3 #378

Merged
merged 1 commit into from
Nov 10, 2024
Merged

[17.0][IMP] fs_attachment: send the mimetype information for S3 #378

merged 1 commit into from
Nov 10, 2024

Conversation

vincent-hatakeyama
Copy link
Contributor

Port of #354

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@vincent-hatakeyama vincent-hatakeyama changed the title [IMP] fs_attachment: send the mimetype information for S3 [17.0][IMP] fs_attachment: send the mimetype information for S3 Jun 24, 2024
@vincent-hatakeyama
Copy link
Contributor Author

Applied suggested changes #354 (comment)

lmignon
lmignon reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincent-hatakeyama I didn't see my suggested changes into thIs PR. Do I miss something?

@vincent-hatakeyama
Copy link
Contributor Author

@vincent-hatakeyama I didn't see my suggested changes into thIs PR. Do I miss something?

Apparently forgot to add the changes or something similar. That’s fixed now.

@vincent-hatakeyama
Copy link
Contributor Author

The Odoo failure is unrelated to these changes; I have the error when running those tests in an image without any non odoo core modules.

@lmignon
Copy link
Contributor

lmignon commented Nov 10, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-378-by-lmignon-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 79d14ba into OCA:17.0 Nov 10, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at eead908. Thanks a lot for contributing to OCA. ❤️

This was referenced Nov 10, 2024
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincent-hatakeyama @OCA-git-bot @lmignon @sebastienbeau