Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] fs_storage: Allow setting eval_options_from_env in configuration file #382

Merged

Conversation

vincent-hatakeyama
Copy link
Contributor

eval_options_from_env can not be set in the configuration file, which prevents using environment variables to avoid displaying the secret key in the UI.

@sbidoul
Copy link
Member

sbidoul commented Jul 12, 2024

Why not, but I have personally not have had problems with this since we set eval_options_from_env when creating the record.

@lmignon
Copy link
Contributor

lmignon commented Nov 10, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-382-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5669584 into OCA:17.0 Nov 10, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6b1f748. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants