Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] fs_attachment: Prevent recompute_urls from skipping records with res_field != False #386

Merged
merged 2 commits into from
Jul 25, 2024
Merged

[16.0][FIX] fs_attachment: Prevent recompute_urls from skipping records with res_field != False #386

merged 2 commits into from
Jul 25, 2024

Conversation

PabloEForgeFlow
Copy link
Contributor

@PabloEForgeFlow PabloEForgeFlow commented Jul 17, 2024 •
edited
Loading

Currently recompute_urls will skip records which have a non-empty res_field, resulting in records with a valid fs_storage_id not being updated. The comment and fix were directly copied from _force_storage_to_object_storage.

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

lmignon
lmignon approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @PabloEForgeFlow

A nice to have should be to have a unittest fot this method

@PabloEForgeFlow PabloEForgeFlow changed the title [16.0][FIX] Prevent recompute_urls from skipping records with res_field != False [16.0][FIX] fs_attachment: Prevent recompute_urls from skipping records with res_field != False Jul 24, 2024
@PabloEForgeFlow
Copy link
Contributor Author

Sorry for the delay, I was a bit busy last week. I have added a test for recompute_urls, let me know what you think.

BernatPForgeFlow
BernatPForgeFlow approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@BernatPForgeFlow BernatPForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks good!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lmignon
Copy link
Contributor

lmignon commented Jul 25, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-386-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 494af25 into OCA:16.0 Jul 25, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 914d91f. Thanks a lot for contributing to OCA. ❤️

dnplkndll pushed a commit to Kencove/storage that referenced this pull request Aug 27, 2024
@vrenaville @lmignon
fix: modifition setup (OCA#386)
acc4811
lmignon pushed a commit to acsone/storage that referenced this pull request Oct 7, 2024
@vrenaville @lmignon
fix: modifition setup (OCA#386)
585dd75
@lmignon lmignon mentioned this pull request Oct 7, 2024
Closed
sbidoul pushed a commit to acsone/storage that referenced this pull request Oct 7, 2024
@vrenaville @sbidoul
fix: modifition setup (OCA#386)
1c2967e
@sbidoul sbidoul mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernatPForgeFlow BernatPForgeFlow BernatPForgeFlow approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PabloEForgeFlow @OCA-git-bot @lmignon @BernatPForgeFlow