Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FW] fs_storage: forward port v16 changes #397

Merged
merged 8 commits into from
Oct 7, 2024

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 5, 2024

Forward port #317, #320, #334, #336, #357, #385

@sbidoul
Copy link
Member Author

sbidoul commented Oct 5, 2024

All clean cherry-picks except the change to USAGE.md which I had to manually convert from USAGE.rst.

@sbidoul sbidoul requested a review from lmignon October 5, 2024 13:07
@sbidoul
Copy link
Member Author

sbidoul commented Oct 5, 2024

I manually compared with 16.0 using pip-wheel-diff "odoo-addon-fs_storage==16.*" git+https://github.com/oca/storage@refs/pull/397/head#subdirectory=fs_storage, it looks complete.

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review, no test)

@lmignon
Copy link
Contributor

lmignon commented Oct 7, 2024

@sbidoul you missed dd62645

@sbidoul
Copy link
Member Author

sbidoul commented Oct 7, 2024

@lmignon it was in #396

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that all changes in 16.0 are included into this PR. Thank you!

@lmignon
Copy link
Contributor

lmignon commented Oct 7, 2024

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-397-by-lmignon-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 40224de into OCA:17.0 Oct 7, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5dfef6a. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 17.0-misc-forward-ports-sbi branch October 7, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants