Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use 0 instead of null values to avoid breaking the plots #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfrer
Copy link
Collaborator

@jfrer jfrer commented Jul 19, 2024

closes #40

@jfrer jfrer requested a review from paulpestov July 19, 2024 12:30
@paulpestov
Copy link
Contributor

Not sure about this. Replacing null by 0 would display wrong data in the charts since 0 is not some default value but an actual measurement. We should have a strategy how to deal with nulls in the data. @MareenGeestmann @mweidling

@jfrer
Copy link
Collaborator Author

jfrer commented Jul 26, 2024

Not sure about this. Replacing null by 0 would display wrong data in the charts since 0 is not some default value but an actual measurement. We should have a strategy how to deal with nulls in the data. @MareenGeestmann @mweidling

Hmm yes, this could be problematic as the user won't know the difference between values that are actually 0 and missing values. However this is also the way that null values are currently handled in the table view (see e.g. the CER standard deviation for "Bettina von Arnim. Tagebuch. 1835." where the values are null for each workflow but 0 is displayed instead).

Also I think that 0 is the correct value for the standard deviation in these cases (because the CER range has the same start- and end-value), but we can't be sure for every other case of course.

@mweidling
Copy link
Contributor

IIRC we decided that the runs where we get nulls should not be considered in the plots but skipped. I don't know how much effort it is to achieve this, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiver timeline, diachronic view - fix values on y-axis to enable comparison (within one metric)
3 participants