Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiver timeline, diachronic view - add legend for color coding #41

Open
MareenGeestmann opened this issue Dec 4, 2023 · 5 comments
Open

Comments

@MareenGeestmann
Copy link

MareenGeestmann commented Dec 4, 2023

Add legend for color coding.
What does a "green", "yellow", and "red" line mean?

green: better
yellow: equal
red: worse
... in comparison to last release.

In fact, it differs between metrics. E. g. for "Pages per minutes" higher values are better while for "CER Mean" lower values are better.
Hence, the legend must fit the metric.

See also: #42

@MareenGeestmann MareenGeestmann changed the title diachronic view - add legend for color coding Quiver timeline, diachronic view - add legend for color coding Dec 4, 2023
@MareenGeestmann
Copy link
Author

Does "positive", "neutral", "negative" refer to the slope?
Why not better, equal, worse?

@paulpestov
Copy link
Contributor

Fixed

@MareenGeestmann
Copy link
Author

I do not understand the coloring - in some cases it is green when values are lower, in other cases when values are larger (within the same metric, e. g. pages per minute).

@paulpestov
Copy link
Contributor

Does it belong to this issue? Maybe you could open a new issue with some examples?

@MareenGeestmann
Copy link
Author

Correct, it does not refer to the legend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants