Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add labels to metric and filter dropdowns, make layout more compact #101

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

jfrer
Copy link
Collaborator

@jfrer jfrer commented Jul 26, 2024

closes #54

@jfrer jfrer requested a review from paulpestov July 26, 2024 16:02
Copy link
Contributor

@paulpestov paulpestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Timeline we have now lots of filters. The placeholder value indicates what is a filter doing. This is a problem because once you select something it only shows "25 selected" but the title/placeholder disappears. Maybe we could place that title (labelling, Script-Type, ...) in small font above the dropdowns.

@jfrer
Copy link
Collaborator Author

jfrer commented Aug 6, 2024

In the Timeline we have now lots of filters. The placeholder value indicates what is a filter doing. This is a problem because once you select something it only shows "25 selected" but the title/placeholder disappears. Maybe we could place that title (labelling, Script-Type, ...) in small font above the dropdowns.

Hmm I would like to use the FloatLabel Component for this, that has been introduced in PrimeVue 3.48, but version 3.48 also deprecates the Tailwind theme we currently use. Should I choose a different theme and use this component or implement the feature by hand? A different theme might be the better choice because otherwise we will be stuck on a version < 3.48 forever. What do you think @paulpestov?

@paulpestov
Copy link
Contributor

In the Timeline we have now lots of filters. The placeholder value indicates what is a filter doing. This is a problem because once you select something it only shows "25 selected" but the title/placeholder disappears. Maybe we could place that title (labelling, Script-Type, ...) in small font above the dropdowns.

Hmm I would like to use the FloatLabel Component for this, that has been introduced in PrimeVue 3.48, but version 3.48 also deprecates the Tailwind theme we currently use. Should I choose a different theme and use this component or implement the feature by hand? A different theme might be the better choice because otherwise we will be stuck on a version < 3.48 forever. What do you think @paulpestov?

Sure feel free to switch the theme. I guess then in with a new PR. I'm approving this one for now.

@jfrer jfrer merged commit edc396b into master Oct 18, 2024
1 check passed
@jfrer jfrer deleted the label-dropdowns branch October 18, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiver timeline - label dropdowns
2 participants