Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiver timeline - add sorting #73

Closed
wants to merge 1 commit into from

Conversation

noornoorie
Copy link
Contributor

Closes #46

@noornoorie
Copy link
Contributor Author

noornoorie commented Apr 8, 2024

@paulpestov Here, I'm parsing the gt ids to get the year since I couldn't find a year property in the metadata. However, as some gt ids (I found at least one) are not guaranteed to have year in them, year sorting doesn't happen properly. What should I do in this case? I think it's better to have a year property in the gt api response?

Also, for sorting by metrics, I'm using the getLatestRuns function to get the runs to sort. However, it seems that for some gt items, api doesn't return data for latest runs. This also breaks the sorting. What should I do in this case? Should I modify the getLatestRuns function to return the last run or should I create a new 'getLastRuns' function?

@paulpestov
Copy link
Contributor

Could you open a regular branch at the quiver-frontend repo and open this PR from there please?

@noornoorie
Copy link
Contributor Author

Could you open a regular branch at the quiver-frontend repo and open this PR from there please?

@paulpestov I've tried to open a regular branch at this repo but got permission denied error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiver timeline - add sorting
2 participants