feat: display more gt metadata in timeline view #79
Conversation
| </a> | ||
| <span v-else-if="meta.isArray">{{ meta.data?.join(', ') }}</span> | ||
| <div v-else-if="meta.isDict" class="flex flex-row space-x-2 px-2"> | ||
| <!-- eslint-disable vue/no-unused-vars --> |
There was a problem hiding this comment.
why those eslint comments?
There was a problem hiding this comment.
Fixed in 65be49d
Not sure why I didn't use (value, key) instead of (value, key, index) in the first place.
Originaly I used _ to mark the index as unused for human readers and added the eslint comments to mark the line for eslint, so that it won't throw an unused var error, because the var was unused on purpose.
There was a problem hiding this comment.
Overall, the font could be "weaker" as the rest of the content, so it does distract from other content. A smaller font.size, lighter color and litte more space on top and bottom could help.
We should talk to @mweidling what is the meaning behind "Volume".
| <button class="font-semibold my-2 flex items-center text-highlight" @click="toggleOpLabelling"> | ||
| <span>{{ $t('labelling') }}</span> | ||
| <Icon v-if="opLabelling?.visible" icon="ic:baseline-close-fullscreen" class="ml-2"></Icon> | ||
| <Icon v-else icon="ic:baseline-open-in-full" class="ml-2"></Icon> |
There was a problem hiding this comment.
Maybe make the whole button more recognizable as button
|
relates to #69