-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes tests to use the correct context to enable async refactor #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r of the code generator.
marabooy
requested review from
paulodero,
KenitoInc,
habbes,
WanjohiSammy and
DButoyez
September 4, 2024 15:11
habbes
reviewed
Sep 6, 2024
src/ODataConnectedService.Shared/ConnectedServiceFileHandler.cs
Outdated
Show resolved
Hide resolved
habbes
reviewed
Sep 6, 2024
habbes
reviewed
Sep 25, 2024
habbes
reviewed
Sep 25, 2024
habbes
reviewed
Sep 25, 2024
src/ODataConnectedService.Shared/ConnectedServiceFileHandler.cs
Outdated
Show resolved
Hide resolved
habbes
reviewed
Sep 25, 2024
src/ODataConnectedService.Shared/ConnectedServiceThreadHelper.cs
Outdated
Show resolved
Hide resolved
habbes
reviewed
Sep 25, 2024
habbes
reviewed
Sep 25, 2024
test/ODataConnectedService.Tests/ViewModels/ConfigOdataEndPointViewModelTests.cs
Outdated
Show resolved
Hide resolved
habbes
reviewed
Sep 25, 2024
test/ODataConnectedService.Tests/ODataConnectedServiceWizardTests.cs
Outdated
Show resolved
Hide resolved
habbes
reviewed
Sep 25, 2024
marabooy
force-pushed
the
ft/refactor-tests
branch
from
September 25, 2024 10:18
09c5c6d
to
4543c96
Compare
habbes
approved these changes
Sep 26, 2024
* move underlying codegen to async
WanjohiSammy
approved these changes
Oct 1, 2024
WanjohiSammy
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors tests and prepares code for #411
Moves all UI tests to use await async and removes the .Wait() call that could hide any async bugs or COM extension communication bugs. Fixes #412
Also introduces the use of Joinable task factory to switch to the background thread https://devblogs.microsoft.com/premier-developer/asynchronous-and-multithreaded-programming-within-vs-using-the-joinabletaskfactory/