Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new spinup option for idealized experiments #33

Merged
merged 16 commits into from
Jul 12, 2023

Conversation

pat-schmitt
Copy link
Member

Here I add some new spinup options, relevant for the idealized experiments.

@coveralls
Copy link

coveralls commented Jun 26, 2023

Pull Request Test Coverage Report for Build 5461803280

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 104 of 156 (66.67%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on add_new_spinup_options at 64.198%

Changes Missing Coverage Covered Lines Changed/Added Lines %
combine1d/core/cost_function.py 55 58 94.83%
combine1d/sandbox/individual_experiment_dashboard.py 0 49 0.0%
Totals Coverage Status
Change from base Build 5356109519: 64.2%
Covered Lines: 2132
Relevant Lines: 3321

💛 - Coveralls

@pat-schmitt
Copy link
Member Author

Here I added two new options for the initialisation of the model:

  1. the possibility to start from the perfectly known initial state (for testing with idealized experiments'
  2. the possibility of using the initial ice volume at each grid point as control. For this, I also added a new regularisation term which prefers a smooth initial ice flux at the start of the modelling time. The idea is that with this new control, the algorithm has many degrees of freedom and by favouring a smooth initial flux I want to minimise the effect of an initial shock. So I tell the algorithm to start from a dynamically more consistent state.

@pat-schmitt pat-schmitt merged commit dc7b607 into OGGM:master Jul 12, 2023
8 checks passed
@pat-schmitt pat-schmitt deleted the add_new_spinup_options branch July 12, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants