Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a suggestion for deleting
required_model_steps
fromFlowlineModel
as a potential optimisation as discussed on slack. I kept some of the logic to make sure the mass balance model updates correctly depending on the defined feedback frequency.Further, I included
max_dt
toFluxBasedModel
, as in the original comment it states thatrequired_model_steps
is used "to prevent 'too large' steps". But not sure if this is really needed.whats-new.rst