Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of route_modifier doesn't mention that the section is named #53

Open
jpo-github-work opened this issue Aug 30, 2022 · 2 comments

Comments

@jpo-github-work
Copy link
Contributor

jpo-github-work commented Aug 30, 2022

Talking about The Wiki page "Route Modifier Plugin"

As the title says, an entry without name doesn't do anything:

[route_modifier]
	matches default_accept
	protocol 106

While a named enty works as expected:

[route_modifier=1]
	matches default_accept
	protocol 106

And I assume, that the section names allow multiple simultaneous modification rules to coexist.

@jpo-github-work
Copy link
Contributor Author

jpo-github-work commented Aug 30, 2022

In addition, the Wiki documentation contradicts README_ROUTE_MODIFIER. The README shows the named configuration but uses filterto match routing targets. According to the sources, the Wiki page is correct and the option is named matches.

@HRogge
Copy link
Contributor

HRogge commented Aug 30, 2022

The wiki has not been updated for a long time... for current parameter 'documentation', use the --schema option of the executable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants