-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] 모임 상세 화면 QA 반영하기 #354
Conversation
- ContentInset은 iOS 15.0에서 deprecated 되어 UIButton.Configuration을 이용하여 설정
- 중간에 표현되는 divider를 UILabel로 구현
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿! 고생하셨습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
짱! 고생하셨어요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
효은아 고생했어!
LGTM
🔗 연결된 이슈
📄 작업 내용
💻 주요 코드 설명
QA 5가지
👀 기타 더 이야기해볼 점
바텀 시트 애니메이션 관련
dismiss
를 호출하다 보니 그렇게 된 것 같은데, 상위 뷰컨트롤러인 BottomSheetController의 메서드를 어떻게 호출해야 할 지에 대한 고민을 해보겠습니다.