[Fix] QA 반영 #359
Merged
[Fix] QA 반영 #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hooni0918
added
✨ feat
Closed
5 tasks
mmaybei
approved these changes
Sep 2, 2024
| @@ -35,6 +35,8 @@ class NicknameViewController: BaseViewController { | |||
| setupTextField() | |||
| setupTapGesture() | |||
| setupNavigationBarTitle(with: "닉네임 설정") | |||
| navigationItem.leftBarButtonItem = nil | |||
|
|
|||
| @@ -136,6 +138,7 @@ class NicknameViewController: BaseViewController { | |||
| .disposed(by: disposeBag) | |||
| view.addGestureRecognizer(tapGesture) | |||
| } | |||
|
|
|||
JinUng41
approved these changes
Sep 2, 2024
Comment on lines
-65
to
+52
| } | ||
| print("uploadProfileImage 함수 호출됨") |
There was a problem hiding this comment.
이 정도의 print문은 삭제해도 좋을 것 같습니다.
Comment on lines
+79
to
+80
| print("프로필 이미지 업로드 성공") | ||
|
|
Comment on lines
+32
to
+50
| func addUnderlineWithMyPage( | ||
| textColor: UIColor, | ||
| underlineColor: UIColor = .gray2, | ||
| spacing: CGFloat = 12 | ||
| ) { | ||
| let font = UIFont.pretendard(.body05) | ||
| let underlineStyle = NSUnderlineStyle.single | ||
|
|
||
| let attributes: [NSAttributedString.Key: Any] = [ | ||
| .font: font, | ||
| .foregroundColor: textColor, | ||
| .underlineStyle: underlineStyle.rawValue, | ||
| .underlineColor: underlineColor, | ||
| .baselineOffset: spacing / 2 | ||
| ] | ||
|
|
||
| let attributedString = NSMutableAttributedString(string: self.titleLabel?.text ?? "", attributes: attributes) | ||
| setAttributedTitle(attributedString, for: .normal) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용
👀 기타 더 이야기해볼 점
테스트 로그인은 배포를 위해 삭제되엇습니다
qa 처리 완료햇습니다
underline새로운 메서드를 추가햇습니다