Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ariaResultsLabel form autosuggest #3471

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/address-input/_macro.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ describe('FOR: Macro: Address-input', () => {
ariaYouHaveSelected: '[params.ariaYouHaveSelected]',
ariaMinChars: '[params.ariaMinChars]',
minChars: '[params.minChars]',
ariaResultsLabel: '[params.ariaResultsLabel]',
ariaOneResult: '[params.ariaOneResult]',
ariaNResults: '[params.ariaNResults]',
ariaLimitedResults: '[params.ariaLimitedResults]',
Expand Down
1 change: 0 additions & 1 deletion src/components/address-input/autosuggest.address.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const EXAMPLE_ADDRESS_INPUT = {
ariaYouHaveSelected: 'You have selected',
ariaMinChars: 'Enter 3 or more characters for suggestions.',
minChars: 3,
ariaResultsLabel: 'Country suggestions',
ariaOneResult: 'There is one suggestion available.',
ariaNResults: 'There are {n} suggestions available.',
ariaLimitedResults: 'Type more characters to improve your search',
Expand Down
2 changes: 0 additions & 2 deletions src/components/autosuggest/autosuggest.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ const EXAMPLE_AUTOSUGGEST = {
ariaYouHaveSelected: 'You have selected',
ariaMinChars: 'Enter 3 or more characters for suggestions.',
minChars: 3,
ariaResultsLabel: 'Country suggestions',
ariaOneResult: 'There is one suggestion available.',
ariaNResults: 'There are {n} suggestions available.',
ariaLimitedResults: 'Type more characters to improve your search',
Expand All @@ -40,7 +39,6 @@ const EXAMPLE_AUTOSUGGEST_WITH_LANGUAGE = {
ariaYouHaveSelected: 'You have selected',
ariaMinChars: 'Enter 3 or more characters for suggestions.',
minChars: 3,
ariaResultsLabel: 'Country suggestions',
ariaOneResult: 'There is one suggestion available.',
ariaNResults: 'There are {n} suggestions available.',
ariaLimitedResults: 'Type more characters to improve your search',
Expand Down
1 change: 0 additions & 1 deletion src/components/header/_macro.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,6 @@ describe('FOR: Macro: Header', () => {
ariaMinChars: 'Enter 3 or more characters for suggestions.',
ariaNResults: 'There are {n} suggestions available.',
ariaOneResult: 'There is one suggestion available.',
ariaResultsLabel: 'Country suggestions',
ariaYouHaveSelected: 'You have selected',
containerClasses: 'ons-autosuggest--header',
id: 'ons-site-search',
Expand Down
1 change: 0 additions & 1 deletion src/components/header/_test-examples.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ export const EXAMPLE_HEADER_NAVIGATION_WITH_SITESEARCHAUTOSUGGEST = {
ariaYouHaveSelected: 'You have selected',
ariaMinChars: 'Enter 3 or more characters for suggestions.',
minChars: 3,
ariaResultsLabel: 'Country suggestions',
ariaOneResult: 'There is one suggestion available.',
ariaNResults: 'There are {n} suggestions available.',
ariaLimitedResults: 'Type more characters to improve your search',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
"instructions": "instructions",
"ariaYouHaveSelected": "ariaYouHaveSelected",
"ariaMinChars": "ariaMinChars",
"ariaResultsLabel": "ariaResultsLabel",
"ariaOneResult": "ariaOneResult",
"ariaNResults": "ariaNResults",
"ariaLimitedResults": "ariaLimitedResults",
Expand Down
1 change: 0 additions & 1 deletion src/components/navigation/_macro.njk
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
"ariaYouHaveSelected":params.siteSearchAutosuggest.ariaYouHaveSelected,
"minChars": params.siteSearchAutosuggest.minChars,
"ariaMinChars": params.siteSearchAutosuggest.ariaMinChars,
"ariaResultsLabel": params.siteSearchAutosuggest.ariaResultsLabel,
"ariaOneResult": params.siteSearchAutosuggest.ariaOneResult,
"ariaNResults": params.siteSearchAutosuggest.ariaNResults,
"ariaLimitedResults": params.siteSearchAutosuggest.ariaLimitedResults,
Expand Down
1 change: 0 additions & 1 deletion src/components/navigation/_macro.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ const SITE_SEARCH_AUTOSUGGEST = {
"Use up and down keys to navigate results once you've typed more than two characters. Use the enter key to select a result. Touch device users, explore by touch or with swipe gestures.",
ariaYouHaveSelected: 'You have selected',
ariaMinChars: 'Enter 3 or more characters for results.',
ariaResultsLabel: 'Search results',
ariaOneResult: 'There is one result available.',
ariaNResults: 'There are {n} results available.',
ariaLimitedResults: 'Results have been limited to 10 results. Type more characters to improve your search',
Expand Down
Loading