From 81bdf26db937020e83624be897d144b93d4d7984 Mon Sep 17 00:00:00 2001 From: petechd <53475968+petechd@users.noreply.github.com> Date: Tue, 17 Sep 2024 12:41:50 +0100 Subject: [PATCH] Fix integration test generator script and makefile command (#1441) * Fix integration test generator script and makefile command * Remove test duplication and no schema name error --- Makefile | 1 - scripts/generate_integration_test.py | 12 +++++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 7b92690e02..7e721c8086 100644 --- a/Makefile +++ b/Makefile @@ -124,6 +124,5 @@ profile: poetry run python profile_application.py generate-integration-test: - poetry run playwright install chromium poetry run python -m scripts.generate_integration_test poetry run black ./scripts/test_* diff --git a/scripts/generate_integration_test.py b/scripts/generate_integration_test.py index c5f9e1efa3..551e129960 100644 --- a/scripts/generate_integration_test.py +++ b/scripts/generate_integration_test.py @@ -91,7 +91,7 @@ def process_launcher_request(request: Request) -> None: with open(output["file_name"], "a", encoding="utf-8") as file: path = f'"{urlparse(request.url).path}"' file.write(generate_method_request(method="get", data=path)) - else: + elif "schema_name" in parse_qs(request.url): # start of journey, so create a skeleton file using the schema name survey_journey["schema_name"] = parse_qs(request.url)["schema_name"][0] output["file_name"] = f"./scripts/{survey_journey['schema_name']}.py" @@ -99,10 +99,14 @@ def process_launcher_request(request: Request) -> None: with open(output["file_name"], "w", encoding="utf-8") as file: # Type ignore: schema_name is taken as string from query string class_name = survey_journey["schema_name"].title().replace("_", "") # type: ignore + function_name = survey_journey["schema_name"] + if not class_name.lower().startswith("test"): + class_name = f"Test{class_name}" + function_name = f"test_{survey_journey['schema_name']}" file.write( TEST_TEMPLATE.format( class_name=class_name, - function_name=survey_journey["schema_name"], + function_name=function_name, schema_name=survey_journey["schema_name"], ) ) @@ -124,7 +128,9 @@ def request_handler(request: Request) -> None: def run(pw: Playwright) -> None: chromium = pw.chromium - browser = chromium.launch(headless=False, args=["--start-maximized"]) + browser = chromium.launch( + headless=False, args=["--start-maximized"], channel="chrome" + ) page = browser.new_page(no_viewport=True) page.goto(LAUNCHER_ROOT_URL)