Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test generator script and makefile command #1441

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

petechd
Copy link
Contributor

@petechd petechd commented Jul 24, 2024

What is the context of this PR?

This adds integration test generator script and makefile changes that we've discussed. Chromium can no longer be downloaded and installed on the latest operating systems for security reasons (it will result in an error when using the makefile command). We need to use Chrome browser as a default and skip the download and install step in Makefile, since Chrome is based on Chromium anyway, we can use it by setting channel parameter. For more info check the docs.

How to review

Check the changes and the behaviour before (you need one of the newer versions of your operating system).

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

Copy link
Contributor

@VirajP1002 VirajP1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All your changes work well 👍

Screenshot 2024-08-01 at 17 25 45

Just a separate minor point (which may be something considered in the past) is when I ran the script for the schema test_checkbox, the test generated was called test_test_checkbox and the same goes for the class name with 2 tests as part of the name, is that something we want to consider avoiding?

@petechd petechd merged commit 81bdf26 into main Sep 17, 2024
17 checks passed
@petechd petechd deleted the integration-test-generator-fixes branch September 17, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants