Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cyclic import #1500

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

remove cyclic import #1500

wants to merge 37 commits into from
+154 −58

Commits on Sep 6, 2024

  1. remove cyclic import

    @Yuyuutsu
    Yuyuutsu committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ec11df9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-cyclic-imports

    @Yuyuutsu
    Yuyuutsu authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5943cc7 View commit details
    Browse the repository at this point in the history

  3. remove trailing white spaces

    @Yuyuutsu
    Yuyuutsu committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    625ddc6 View commit details
    Browse the repository at this point in the history

  4. remove type ignore labels

    @Yuyuutsu
    Yuyuutsu committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    fd4b580 View commit details
    Browse the repository at this point in the history

  5. remove trailing white space

    @Yuyuutsu
    Yuyuutsu committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    63a006e View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Merge branch 'main' into fix-cyclic-imports

    @Yuyuutsu
    Yuyuutsu authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    aa2d551 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'main' into fix-cyclic-imports

    @Yuyuutsu
    Yuyuutsu authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9827787 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Use imports inside function - Solution 1

    @Yuyuutsu
    Yuyuutsu committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4618a71 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. rempve cylic imports with reule evaluator and value source resolver

    @Yuyuutsu
    Yuyuutsu committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9f21590 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. revert import changes for placehodler and praser

    @Yuyuutsu
    Yuyuutsu committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    aa24fc7 View commit details
    Browse the repository at this point in the history

  2. add new Abstract class for Evalutaor

    @Yuyuutsu
    Yuyuutsu committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6f22786 View commit details
    Browse the repository at this point in the history

  3. fix import linting for placeolder parser in rednerer

    @Yuyuutsu
    Yuyuutsu committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    951d42f View commit details
    Browse the repository at this point in the history

  4. fix mpy issues about missing arguemnt rule ecaluator

    @Yuyuutsu
    Yuyuutsu committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7f187f9 View commit details
    Browse the repository at this point in the history

  5. fix missing rule evlauator paramters in VSR

    @Yuyuutsu
    Yuyuutsu committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    012f3a4 View commit details
    Browse the repository at this point in the history

  6. update tests to use pass evalutaor in value source resolver

    @Yuyuutsu
    Yuyuutsu committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    170f0b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. revert type ignore for hub context

    @Yuyuutsu
    Yuyuutsu committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3c70289 View commit details
    Browse the repository at this point in the history

  2. update comment formatting for hub context

    @Yuyuutsu
    Yuyuutsu committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e527b92 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix-cyclic-imports

    @Yuyuutsu
    Yuyuutsu authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ca4e7f7 View commit details
    Browse the repository at this point in the history

  4. revmove trailing white space

    @Yuyuutsu
    Yuyuutsu committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5b9220c View commit details
    Browse the repository at this point in the history

  5. add renderer abstract class

    @Yuyuutsu
    Yuyuutsu committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2469d8b View commit details
    Browse the repository at this point in the history

  6. Add Value Source Resolver as Paramter for Rule Evalator Class

    @Yuyuutsu
    Yuyuutsu committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2acff21 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'main' into fix-cyclic-imports

    @Yuyuutsu
    Yuyuutsu authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0043e9a View commit details
    Browse the repository at this point in the history

  2. fix function calling of pyfixtue

    @Yuyuutsu
    Yuyuutsu committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d59afbb View commit details
    Browse the repository at this point in the history

  3. update tests for rule evaluator

    @Yuyuutsu
    Yuyuutsu committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    bb42b8c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Update Rule Evaluator to have default answer true

    @Yuyuutsu
    Yuyuutsu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3151ce4 View commit details
    Browse the repository at this point in the history

  2. update valuesourceresolver objects that are passed into Rule Evaluato… 

    …r to have use_default_answer=True

Signed-off-by: Yuyutsu Rai <Yuyutsu.Rai@ons.gov.uk>
    @Yuyuutsu
    Yuyuutsu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    52878b8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix-cyclic-imports

    @Yuyuutsu
    Yuyuutsu authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    026c8cc View commit details
    Browse the repository at this point in the history

  4. fix incorrect paramters in Rule Evaluator 

    Signed-off-by: Yuyutsu Rai <Yuyutsu.Rai@ons.gov.uk>
    @Yuyuutsu
    Yuyuutsu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6b9b9e4 View commit details
    Browse the repository at this point in the history

  5. fix incorrect paramters in rule evaluator

    @Yuyuutsu
    Yuyuutsu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    62de00c View commit details
    Browse the repository at this point in the history

  6. remove defualt answer from Rule Eval Param

    @Yuyuutsu
    Yuyuutsu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6673b5b View commit details
    Browse the repository at this point in the history

  7. add a pylint disable for redefined outer name in confest.py

    @Yuyuutsu
    Yuyuutsu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bf07a26 View commit details
    Browse the repository at this point in the history

  8. Update Test Dynamic Answers pytest fixtures 

    Signed-off-by: Yuyutsu Rai <Yuyutsu.Rai@ons.gov.uk>
    @Yuyuutsu
    Yuyuutsu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9de3d1c View commit details
    Browse the repository at this point in the history

  9. update pytest coverage to ignore abstract classes

    @Yuyuutsu
    Yuyuutsu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4f7f443 View commit details
    Browse the repository at this point in the history

  10. update renderer abstract class

    @Yuyuutsu
    Yuyuutsu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    cfcaa2b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. remove renderer abstract class 

    Signed-off-by: Yuyutsu Rai <Yuyutsu.Rai@ons.gov.uk>
    @Yuyuutsu
    Yuyuutsu committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1409742 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. re-add pylint ignore

    @Yuyuutsu
    Yuyuutsu committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5cb5bd8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-cyclic-imports

    @Yuyuutsu
    Yuyuutsu authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9b56536 View commit details
    Browse the repository at this point in the history