Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hub submit and npm caches #1532

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Remove hub submit and npm caches #1532

merged 2 commits into from
Oct 11, 2024

Conversation

berroar
Copy link
Contributor

@berroar berroar commented Oct 10, 2024

What is the context of this PR?

Removes a line from the new_calculated_summary_repeating_and_static_answers functional test suite that was leading to flaky test issues. The line removed was not needed, as the schema does not render the Hub page on Launch.

Also removes the npm caches in our Actions workflow as they were added to provide performance benefit but not having any real impact at the moment. It maybe having an adverse affect on our flakyness and we are going to progress a ticket to investigate our npm and actions workflow separately.

How to review

Check that the updated test passes.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@berroar berroar marked this pull request as ready for review October 10, 2024 09:49
@berroar berroar changed the title Remove hub submit Remove hub submit and npm caches Oct 10, 2024
@berroar berroar merged commit 3eb3929 into main Oct 11, 2024
16 checks passed
@berroar berroar deleted the calc-summary-func-test branch October 11, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants