-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use FastAPI #252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the run_app.sh
might need to be updated with the new command as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected through Runner.
This part of the Make Run Command does not work : poetry run ./scripts/run_app.sh
.
Edit: Did not see liam already make a comment on this sorry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Tested locally
What is the context of this PR?
To improve validator performance we want to use a framework that supports concurrency. Mainly changes to Flask libraries specific code were made, they were replaced with FastAPI equivalents. I've reduced the number of modules and put the endpoints logic in the main file, since the codebase for the initial app is minimal in size. Some new logic added since FastAPI modules behave slightly different, mainly around data received in requests sent.
How to review
Run it with Runner locally, ideally by pulling validator docker images and using make commands like
make run-validator
etc. using docker images and relevant branch of Runner.Checklist