Add method overloads to support using qualifiers for SDK components #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a "qualifier" parameter in several methods in the TranslatorDependencyFactory interface, so implementers must be updated. Update DependencyFactoryMock in the unit tests accordingly.
rousso
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "qualifier" parameter in several methods in the TranslatorDependencyFactory interface, so this breaks backwards compatibility, and all implementation of this interface must be updated.
There other possible way to do this that have less impact, but I went for the cleanest way as the toolkit is in "alpha" versions.
This requires the changes in eforms-core from the PR at OP-TED/eforms-core-java#33.
The build will fail until that PR is merged, so this PR is a draft until then.