Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/26 업로드 모달 구현 #33

Merged
merged 15 commits into from
Aug 18, 2021
Merged

Feature/26 업로드 모달 구현 #33

merged 15 commits into from
Aug 18, 2021

Conversation

hanbin9775
Copy link
Collaborator

@hanbin9775 hanbin9775 commented Aug 15, 2021 •
edited
Loading

  • uploadModalStepAtom, uploadModalPopStateAtom 구현
  • 업로드는 아직 배포안된 api에 연동. (박건님에게 구조를 물어봐서 그것을 바탕으로 구현)
  • 모달 컴포넌트의 삽입 위치 고민중.. (어쩌피 메인에서만 보는 컴포넌트니깐 메인에 두는게 맞나? 근데 또 실제 업로드 모달 띄우는 버튼은 leftNav에 있음)

gigibean and others added 12 commits August 11, 2021 15:38
@gigibean
[#26] update Modal base
30c1158 
* 모달 공통모듈 wrapper (width height borderRadius) 추가
* 비디오 모달 비디오 가로 비율 맞춤
* 비디오 모달 비디오 백그라운드 #000로 변환
*메인 페이지에 임의 upload button 추가
* 임의 upload button에 upload 모달 연결
@gigibean
[#26] update modal & create upload, upload firstcontent
d3444d2
@hanbin9775
[#26] feat: file(video) read and render
f1e7446
@gigibean
[#26] upload upload
122ec41 
* 모달 페이지 분리
* 모달 레이아웃
* 모달 버튼 구현
* 모달 사진 이어지는 기능 구현

- [ ] 모달 마지막 페이지 구현
- [ ] axios 로 백 연결
- [ ] x아이콘과 마지막 버튼에 모달 닫기 추가
@gigibean
Update SecondContent.tsx
ea0f875
@hanbin9775
feat: UploadModal step atom implemented
e5b1230
@hanbin9775
fix: SecondContent Button Style condition fixed
c764144
@hanbin9775
[#26] feat: UploadModal ThirdContent Component implemented
dacad13
@hanbin9775
Merge branch 'master' of https://github.com/OPGG-HACKTHON/web-e-front …
6be2b72 
…into feature/26
@hanbin9775
Merge branch 'master' of https://github.com/OPGG-HACKTHON/web-e-front …
ee240cc 
…into feature/26
@hanbin9775
[#26] feat: Video src, description, category upload implemented
bda5eba
@hanbin9775
[#26] fix: 업로드 버튼 leftNav로 이동. 로그인시에만 업로드 가능.
bed3215 
add: uploadModalPopStateAtom
@hanbin9775 hanbin9775 self-assigned this Aug 15, 2021
SoonGwan
SoonGwan approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@SoonGwan SoonGwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
일이 많아서 이제 코드를 봅니당 ㅠㅠ

@SoonGwan
Copy link
Member

문뜩 든 생각인데 저희 다 작업하는 코드 보니 위에 eslint-disabled 주석이 엄청 많네요....
지금 eslint 설정을 보니 prettier 랑 안맞는 부분도 있구, 저희 짜는 스타일이랑 다른 느낌이 많이 드네요...
이번주 목요일 정기 회의때 한번 덜어내야 할지 한번 의견 맞춰 봅시당 :)

@SoonGwan SoonGwan merged commit bacdca3 into master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoonGwan SoonGwan SoonGwan approved these changes

@gigibean gigibean Awaiting requested review from gigibean

Assignees

@hanbin9775 hanbin9775

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanbin9775 @SoonGwan @gigibean