Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backup_label : return immediately CRITICAL on secondary, or when pg_is_in_backup() = false #322

Open
Krysztophe opened this issue Jul 8, 2022 · 2 comments
Open

backup_label : return immediately CRITICAL on secondary, or when pg_is_in_backup() = false #322

Krysztophe opened this issue Jul 8, 2022 · 2 comments
Labels
enhancement good first issue

Comments

@Krysztophe
Copy link
Collaborator

  • A backup_label on a secondary server is not normal and dangerous.
    The service should return CRITICAL immediately.

  • If pg_is_backup () is false, it should return CRITICAL too
    (that would cover the previous case).
@frost242
Copy link
Member

frost242 commented Oct 20, 2022 •
edited
Loading

Hello,

Edit: sorry, I lack sleep. Will get back here after some good sleep...

@frost242
Copy link
Member

frost242 commented Dec 6, 2022

Hello,
I've just pushed some changes regarding backup_label_age, but this does not address this issue. Are you willing to push a PR to fix this in the near future ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frost242 @Krysztophe