Aorsa test #56
Merged
Aorsa test #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly fit within params%snapshot_frequency
…harges (did not check collision operators and radiation, experimental distribution sampling hard-wired for electrons), included uniform_fields_GC_p
…cation of all GC spp%vars fields made standard
Trying to update my local korc repository
|
Test this please |
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
quantumsteve
reviewed
Sep 3, 2024
innocuous_file.txt
Outdated
…g hammersley operator for RNG in uniform distributions
|
test this please |
… after logs echoed
|
test this please |
|
please test |
|
This is working on gnu 12.2 and nvhpc 23.9 (for cpu and gpu) on my machine and gnu 11.4 for CPU and nvhpc 24.5 for GPU on ExCL. This is only not working on github cloud (Agate) with gnu 13.2 and appears to be an issue with the openmp. I am going to merge this branch and the mars MPI branch and open a new pull request where I will gut the openmp now that it is not being used for CPU thread/vector parallelism. We will likely return to openmp for GPU offload in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging old AORSA branches and developing test