-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and unify the random numbers. #42
Conversation
@idigs @cianciosa Do you see an error message from |
I'm guessing the test failure is a result of differences in seeding. Do you know if this test uses a constant seed? |
The initial case I provided may use a different seed than the present case. |
I think it's a Chrome or GitHub issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good on my computer. When I run it multiple times, I keep getting the same exact results with a good distributions of REs. The only issue is that I am getting different answers compared to what Mark sent me by email on 6/5/24. While the spatial distribution is different.
…t to refer to this new file in ctest
test this please |
@idigs it looks like the SPACK cache is getting built and created again. Can we set it up a workflow to have this to happen automatically on a weekend evening? |
test this please |
@idigs, how long does it usually take for an ExCL runner to pick up the Onyx workflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't do comprehensive testing due to size, but works for mars regression CTest.
This unifies and cleans up the random number generation to ensure that random numbers are seeded once at the beginning.