Anchor refactor #39
Merged
Anchor refactor #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly changes how icat itself interfaces with anchors. Rather than a user being able to specify and pass similarity functions, the assumption is that the user subclasses
SimilarityAnchorBase(the only function that has to be overriden isfeaturize(), which is where any previous similarity function code would go.)The anchorlist is much better now! There's a separate tab now for interacting with anchor types - ICAT automatically detects any and all anchor subclasses in scope and dynamically populates this tab allowing you to add and remove the types (adding corresponding "anchor add" buttons in the main anchorlist), rename them, and change the color in the interface associated with them. Anchor type colors are used in the anchorlist itself (as well as anchorviz) to help distinguish what anchors are what.
A settings tab in the anchorlist lets you set which anchor type is used when you click the "example" button in the data manager. (The only types that can be used are those that subclass
SimilarityAnchorBase)